Skip to content

fix: broken transcript with multiple files per message #38064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 5 commits into from
Jan 7, 2026
Merged

fix: broken transcript with multiple files per message #38064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6e5300b
chore: add multifiles case to `pdf-worker` story
juliajforesti Jan 5, 2026
9edfff7
fix: add message and file wrapping for multifiles scenario
juliajforesti Jan 5, 2026
3790e42
chore: changeset
juliajforesti Jan 5, 2026
4c4cc0a
Merge branch 'develop' into fix/pdf-worker-multi-files
dougfabris Jan 7, 2026
7c234e2
Merge branch 'develop' into fix/pdf-worker-multi-files
kodiakhq[bot] Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/flat-berries-sell.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@rocket.chat/pdf-worker': patch
---

Fixes broken chat transcript when there are more than one file per message
9 changes: 8 additions & 1 deletion ee/packages/pdf-worker/src/templates/ChatTranscript/ChatTranscript.fixtures.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,14 @@ export const exampleData: WorkerData = {
name: 'Christian Castro',
username: 'cristiano.castro',
},
files: [{ name: 'screenshot.png', buffer: Buffer.from(base64Image, 'base64') }],
files: [
{ name: 'screenshot.png', buffer: Buffer.from(base64Image, 'base64') },
{ name: 'screenshot.png', buffer: Buffer.from(base64Image, 'base64') },
{ name: 'screenshot.png', buffer: Buffer.from(base64Image, 'base64') },
{ name: 'screenshot.png', buffer: Buffer.from(base64Image, 'base64') },
{ name: 'screenshot.png', buffer: Buffer.from(base64Image, 'base64') },
{ name: 'screenshot.png', buffer: Buffer.from(base64Image, 'base64') },
],
},
{
msg: 'Thank you, I am checking on that for you now.',
Expand Down
18 changes: 13 additions & 5 deletions ee/packages/pdf-worker/src/templates/ChatTranscript/components/Files.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,22 @@ import { fontScales } from '@rocket.chat/fuselage-tokens/typography.json';
import type { PDFFile } from '../../../types/ChatTranscriptData';

const styles = StyleSheet.create({
container: {
marginTop: 8,
width: '100%',
},
file: {
color: colors.n700,
marginTop: 4,
marginBottom: 16,
flexDirection: 'column',
fontSize: fontScales.c1.fontSize,
width: '100%',
},
fileName: {
marginBottom: 6,
},
image: {
width: 400,
width: '100%',
maxHeight: 240,
objectFit: 'contain',
objectPosition: '0',
Expand All @@ -31,10 +39,10 @@ const styles = StyleSheet.create({
});

export const Files = ({ files, invalidMessage }: { files: PDFFile[]; invalidMessage: string }) => (
<View wrap={false}>
<View style={styles.container}>
{files?.map((file, index) => (
<View style={styles.file} key={index}>
<Text>{file.name}</Text>
<View style={styles.file} key={index} wrap>
<Text style={styles.fileName}>{file.name}</Text>
{file.buffer ? (
// Cache = false is required to avoid a bug in react-pdf
// Which causes the image to be duplicated when using buffers because of bad caching
Expand Down
2 changes: 1 addition & 1 deletion ee/packages/pdf-worker/src/templates/ChatTranscript/components/Message.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ const processMessage = (message: PDFMessage) => {
};

const Message = ({ message, invalidFileMessage }: { message: PDFMessage; invalidFileMessage: string }) => (
<View style={styles.wrapper} wrap={!!message.quotes || messageLongerThanPage(message.msg)}>
<View style={styles.wrapper} wrap={!!message.quotes || messageLongerThanPage(message.msg) || (message.files && message.files.length > 0)}>
{message.divider && <Divider divider={message.divider} />}
<MessageHeader name={message.u.name || message.u.username} time={message.ts} />

Expand Down
Loading