Skip to content

fix: no ringing timeout on transferred calls #38025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 1 commit into from
Jan 5, 2026
Merged

fix: no ringing timeout on transferred calls #38025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/violet-cats-lick.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@rocket.chat/media-signaling': patch
---

Adds a timeout to ensure transferred calls stop ringing if there's no response from the final user
5 changes: 2 additions & 3 deletions packages/media-signaling/src/lib/Call.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,9 +349,8 @@ export class ClientMediaCall implements IClientMediaCall {
// Send an ACK so the server knows that this session exists and is reachable
this.acknowledge();

if (this._role === 'callee' || !this.acceptedLocally) {
this.addStateTimeout('pending', TIMEOUT_TO_ACCEPT);
}
// Adds a secondary timeout for all sessions of the call; Won't matter if the original caller session is still active, but is needed for transferred calls.
this.addStateTimeout('pending', TIMEOUT_TO_ACCEPT);

// If the call was requested by this specific session, assume we're signed already.
if (
Expand Down
Loading