Skip to content

regression: fixes undefined user-agent on device login detection #38010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 2 commits into from
Dec 30, 2025
Merged

regression: fixes undefined user-agent on device login detection #38010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb69bb0
regression: fixes undefined user-agent on device login detection (#37…
lucas-a-pelegrino Dec 1, 2025
14e607d
docs: adds changeset
lucas-a-pelegrino Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/healthy-rabbits-sip.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@rocket.chat/meteor": patch
---

Fixes an issue where `user-agent` is not properly extracted from the DDP connection headers
7 changes: 6 additions & 1 deletion apps/meteor/ee/server/lib/deviceManagement/session.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,12 @@ export const listenSessionLogin = () => {
username,
emails: [{ address: email }],
} = user;
const { browser, os, device, cpu, app } = await uaParser(connection.httpHeaders['user-agent']);

const userAgentString =
connection.httpHeaders instanceof Headers
? (connection.httpHeaders.get('user-agent') ?? '')
: (connection.httpHeaders['user-agent'] ?? '');
const { browser, os, device, cpu, app } = await uaParser(userAgentString);

const mailData = {
name,
Expand Down
Loading