From ca6da7ace903974deca29ee79c148b63025517e7 Mon Sep 17 00:00:00 2001 From: MartinSchoeler Date: Tue, 23 Dec 2025 14:16:57 -0300 Subject: [PATCH 1/3] regression(ABAC): list not updating when room change --- .../client/views/admin/ABAC/ABACRoomsTab/RoomsContextualBar.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/meteor/client/views/admin/ABAC/ABACRoomsTab/RoomsContextualBar.tsx b/apps/meteor/client/views/admin/ABAC/ABACRoomsTab/RoomsContextualBar.tsx index 25c9037c86e67..d498db0592733 100644 --- a/apps/meteor/client/views/admin/ABAC/ABACRoomsTab/RoomsContextualBar.tsx +++ b/apps/meteor/client/views/admin/ABAC/ABACRoomsTab/RoomsContextualBar.tsx @@ -64,7 +64,7 @@ const RoomsContextualBar = ({ roomInfo, attributesData, onClose }: RoomsContextu dispatchToastMessage({ type: 'error', message: error }); }, onSettled: () => { - queryClient.invalidateQueries({ queryKey: ABACQueryKeys.rooms.list() }); + queryClient.invalidateQueries({ queryKey: ABACQueryKeys.rooms.list({}) }); }, }); From 635bf1dc8ea447dde66f350043c6a039383b94e2 Mon Sep 17 00:00:00 2001 From: Tasso Date: Wed, 24 Dec 2025 09:47:58 -0300 Subject: [PATCH 2/3] refactor: better approach for optional segments in query key factories --- apps/meteor/client/lib/queryKeys.ts | 8 ++++---- .../views/admin/ABAC/ABACRoomsTab/RoomsContextualBar.tsx | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/apps/meteor/client/lib/queryKeys.ts b/apps/meteor/client/lib/queryKeys.ts index a619b03178100..8dff5a6068991 100644 --- a/apps/meteor/client/lib/queryKeys.ts +++ b/apps/meteor/client/lib/queryKeys.ts @@ -128,17 +128,17 @@ export const ABACQueryKeys = { all: ['abac'] as const, logs: { all: () => [...ABACQueryKeys.all, 'logs'] as const, - list: (query?: PaginatedRequest) => [...ABACQueryKeys.logs.all(), 'list', query] as const, + list: (...args: [query?: PaginatedRequest]) => [...ABACQueryKeys.logs.all(), 'list', ...args] as const, }, roomAttributes: { all: () => [...ABACQueryKeys.all, 'room-attributes'] as const, - list: (query?: PaginatedRequest) => [...ABACQueryKeys.roomAttributes.all(), query] as const, + list: (...args: [query?: PaginatedRequest]) => [...ABACQueryKeys.roomAttributes.all(), ...args] as const, attribute: (attributeId: string) => [...ABACQueryKeys.roomAttributes.all(), attributeId] as const, }, rooms: { all: () => [...ABACQueryKeys.all, 'rooms'] as const, - list: (query?: PaginatedRequest) => [...ABACQueryKeys.rooms.all(), query] as const, - autocomplete: (query?: PaginatedRequest) => [...ABACQueryKeys.rooms.all(), 'autocomplete', query] as const, + list: (...args: [query?: PaginatedRequest]) => [...ABACQueryKeys.rooms.all(), ...args] as const, + autocomplete: (...args: [query?: PaginatedRequest]) => [...ABACQueryKeys.rooms.all(), 'autocomplete', ...args] as const, room: (roomId: string) => [...ABACQueryKeys.rooms.all(), roomId] as const, }, }; diff --git a/apps/meteor/client/views/admin/ABAC/ABACRoomsTab/RoomsContextualBar.tsx b/apps/meteor/client/views/admin/ABAC/ABACRoomsTab/RoomsContextualBar.tsx index d498db0592733..25c9037c86e67 100644 --- a/apps/meteor/client/views/admin/ABAC/ABACRoomsTab/RoomsContextualBar.tsx +++ b/apps/meteor/client/views/admin/ABAC/ABACRoomsTab/RoomsContextualBar.tsx @@ -64,7 +64,7 @@ const RoomsContextualBar = ({ roomInfo, attributesData, onClose }: RoomsContextu dispatchToastMessage({ type: 'error', message: error }); }, onSettled: () => { - queryClient.invalidateQueries({ queryKey: ABACQueryKeys.rooms.list({}) }); + queryClient.invalidateQueries({ queryKey: ABACQueryKeys.rooms.list() }); }, }); From 963b4cd6ac28eae37bdfc12462e27b8e30b89cfe Mon Sep 17 00:00:00 2001 From: MartinSchoeler Date: Wed, 24 Dec 2025 10:32:10 -0300 Subject: [PATCH 3/3] chore: update attribute list query key too --- .../admin/ABAC/ABACAttributesTab/AttributesContextualBar.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/meteor/client/views/admin/ABAC/ABACAttributesTab/AttributesContextualBar.tsx b/apps/meteor/client/views/admin/ABAC/ABACAttributesTab/AttributesContextualBar.tsx index a1f22fd11a1dd..a41e7b6b87ca2 100644 --- a/apps/meteor/client/views/admin/ABAC/ABACAttributesTab/AttributesContextualBar.tsx +++ b/apps/meteor/client/views/admin/ABAC/ABACAttributesTab/AttributesContextualBar.tsx @@ -75,7 +75,7 @@ const AttributesContextualBar = ({ attributeData, onClose }: AttributesContextua dispatchToastMessage({ type: 'error', message: error }); }, onSettled: () => { - queryClient.invalidateQueries({ queryKey: ABACQueryKeys.roomAttributes.list({}) }); + queryClient.invalidateQueries({ queryKey: ABACQueryKeys.roomAttributes.list() }); }, });