@@ -570,7 +569,6 @@ exports[`renders DefaultVersion2 without crashing 1`] = `
diff --git a/apps/meteor/client/sidebar/header/CreateDirectMessage.tsx b/apps/meteor/client/sidebar/header/CreateDirectMessage.tsx
index acfac1c479c3e..6610962cb4f1e 100644
--- a/apps/meteor/client/sidebar/header/CreateDirectMessage.tsx
+++ b/apps/meteor/client/sidebar/header/CreateDirectMessage.tsx
@@ -20,7 +20,7 @@ import { useMutation } from '@tanstack/react-query';
import { useId, memo } from 'react';
import { useForm, Controller } from 'react-hook-form';
-import UserAutoCompleteMultipleFederated from '../../components/UserAutoCompleteMultiple/UserAutoCompleteMultipleFederated';
+import UserAutoCompleteMultiple from '../../components/UserAutoCompleteMultiple';
import { goToRoomById } from '../../lib/utils/goToRoomById';
const CreateDirectMessage = ({ onClose }: { onClose: () => void }) => {
@@ -76,11 +76,12 @@ const CreateDirectMessage = ({ onClose }: { onClose: () => void }) => {
}}
control={control}
render={({ field: { name, onChange, value, onBlur } }) => (
-
@@ -540,27 +546,33 @@ exports[`renders DefaultVersion2 without crashing 1`] = `
Teams_New_Add_members_Label
diff --git a/apps/meteor/client/views/audit/components/tabs/DirectTab.tsx b/apps/meteor/client/views/audit/components/tabs/DirectTab.tsx
index 7e74c5263978a..5be7564fa6190 100644
--- a/apps/meteor/client/views/audit/components/tabs/DirectTab.tsx
+++ b/apps/meteor/client/views/audit/components/tabs/DirectTab.tsx
@@ -33,7 +33,7 @@ const DirectTab = ({ form: { control } }: DirectTabProps): ReactElement => {
diff --git a/apps/meteor/client/views/audit/components/tabs/UsersTab.tsx b/apps/meteor/client/views/audit/components/tabs/UsersTab.tsx
index 02cf1fa6f2fda..40cc292ad2bec 100644
--- a/apps/meteor/client/views/audit/components/tabs/UsersTab.tsx
+++ b/apps/meteor/client/views/audit/components/tabs/UsersTab.tsx
@@ -32,7 +32,7 @@ const UsersTab = ({ form: { control } }: UsersTabProps): ReactElement => {
{t('Users')}
users.some((user) => user.startsWith('@'));
@@ -38,6 +37,7 @@ const AddUsers = ({ rid, onClickBack, reload }: AddUsersProps): ReactElement =>
const roomIsFederated = isRoomFederated(room);
// we are dropping the non native federation for now
const isFederationBlocked = room && !isRoomNativeFederated(room);
+ const isFederated = roomIsFederated && !isFederationBlocked;
const { closeTab } = useRoomToolbox();
const saveAction = useMethod('addUsersToRoom');
@@ -73,24 +73,21 @@ const AddUsers = ({ rid, onClickBack, reload }: AddUsersProps): ReactElement =>
{t('Choose_users')}
- {roomIsFederated ? (
- !isFederationBlocked && (
- }
+ !isFederated && (!hasExternalUsers(users) || t('You_cannot_add_external_users_to_non_federated_room')),
+ }}
+ render={({ field }) => (
+
- )
- ) : (
- !hasExternalUsers(users) || t('You_cannot_add_external_users_to_non_federated_room') }}
- render={({ field }) => (
-
- )}
- />
- )}
+ )}
+ />
{errors.users && (
{errors.users.message}
diff --git a/apps/meteor/tests/e2e/administration.spec.ts b/apps/meteor/tests/e2e/administration.spec.ts
index 00add48b595db..5769794f13f3d 100644
--- a/apps/meteor/tests/e2e/administration.spec.ts
+++ b/apps/meteor/tests/e2e/administration.spec.ts
@@ -311,7 +311,7 @@ test.describe.parallel('administration', () => {
await poAdminRoles.inputRoom.fill(channelName);
await page.getByRole('option', { name: channelName }).click();
- await poAdminRoles.inputUsers.fill('user1');
+ await poAdminRoles.inputUsers.pressSequentially('user1');
await page.getByRole('option', { name: 'user1' }).click();
await poAdminRoles.btnAdd.click();
diff --git a/apps/meteor/tests/e2e/page-objects/fragments/home-flextab-members.ts b/apps/meteor/tests/e2e/page-objects/fragments/home-flextab-members.ts
index 10ac01af28b66..d23622e7d70f5 100644
--- a/apps/meteor/tests/e2e/page-objects/fragments/home-flextab-members.ts
+++ b/apps/meteor/tests/e2e/page-objects/fragments/home-flextab-members.ts
@@ -30,8 +30,8 @@ export class HomeFlextabMembers {
async addUser(username: string) {
await this.page.locator('role=button[name="Add"]').click();
- await this.page.locator('//label[contains(text(), "Choose users")]/..//input').fill(username);
- await this.page.locator(`[data-qa-type="autocomplete-user-option"] >> text=${username}`).first().click();
+ await this.page.getByRole('textbox', { name: 'Choose users' }).pressSequentially(username);
+ await this.page.getByRole('option', { name: username }).click();
await this.page.locator('role=button[name="Add users"]').click();
}
diff --git a/apps/meteor/tests/e2e/page-objects/home-team.ts b/apps/meteor/tests/e2e/page-objects/home-team.ts
index f44b2584f7f27..150e6a8108aef 100644
--- a/apps/meteor/tests/e2e/page-objects/home-team.ts
+++ b/apps/meteor/tests/e2e/page-objects/home-team.ts
@@ -30,8 +30,8 @@ export class HomeTeam {
}
async addMember(memberName: string): Promise {
- await this.page.locator('role=textbox[name="Members"]').type(memberName, { delay: 100 });
- await this.page.locator(`.rcx-option__content:has-text("${memberName}")`).click();
+ await this.page.getByRole('textbox', { name: 'Add people' }).pressSequentially(memberName, { delay: 100 });
+ await this.page.getByRole('option', { name: memberName }).click();
}
get btnTeamCreate(): Locator {