Skip to content

chore: trigger a renegotiation when a call is put on hold #37383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pierre-lehnen-rc merged 3 commits into from
Nov 5, 2025
Merged

chore: trigger a renegotiation when a call is put on hold #37383

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f4fec35
chore: trigger a renegotiation when a call is put on hold
pierre-lehnen-rc Nov 4, 2025
84209bf
Merge branch 'feat/voip-sync-audio-direction' into chore/held-call-tr…
pierre-lehnen-rc Nov 5, 2025
15ac394
Merge branch 'feat/voip-sync-audio-direction' into chore/held-call-tr…
tassoevan Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions packages/media-signaling/src/lib/services/webrtc/Processor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,8 @@ export class MediaCallWebRTCProcessor implements IWebRTCProcessor {
this._held = held;
this.localStream.setEnabled(!held && !this._muted);
this.remoteStream.setEnabled(!held);

this.updateAudioDirectionWithoutNegotiation();
}

public stop(): void {
Expand Down Expand Up @@ -387,6 +389,28 @@ export class MediaCallWebRTCProcessor implements IWebRTCProcessor {
.filter((transceiver) => transceiver.sender.track?.kind === 'audio' || transceiver.receiver.track?.kind === 'audio');
}

private updateAudioDirectionWithoutNegotiation(): void {
// If the signaling state is not stable, then a negotiation is already happening and the audio direction will be updated by them
if (this.peer.signalingState !== 'stable') {
return;
}

const desiredDirection = this.held ? 'sendonly' : 'sendrecv';
const acceptableDirection = this.held ? 'inactive' : 'recvonly';

const transceivers = this.getAudioTransceivers();
for (const transceiver of transceivers) {
// If the last direction we requested still matches our current requirements, then we don't need to change our request
if ([desiredDirection, acceptableDirection, 'stopped'].includes(transceiver.direction)) {
continue;
}

// If the current state of the call doesn't match what we are requesting here, the browser will trigger the negotiation-needed event for us
this.config.logger?.debug(`Changing desired audio direction from ${transceiver.direction} to ${desiredDirection}.`);
transceiver.direction = desiredDirection;
}
}

private registerPeerEvents() {
const { peer } = this;

Expand Down
Loading