-
Notifications
You must be signed in to change notification settings - Fork 13k
chore(federation): add settings watcher #37289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
f29e839
add watcher for federation settings and update config service when it…
ricardogarim b48a1ae
fix service init
ricardogarim 1d4cfa6
fix: register federation routes only once
ricardogarim 616c805
fix: prevent duplicate StreamerCentral listener registration
ricardogarim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Fix TypeScript compilation error:
updateConfigmethod does not exist.The pipeline failure indicates that
updateConfigis not a property ofConfigService. According to the PR description, this relies on homeserver PR #289 which implements the method.Verify the following:
Additionally, check the package version of
@rocket.chat/federation-sdkto ensure it includes theupdateConfigmethod:If the method doesn't exist yet, this PR should either:
updateConfigmethod🏁 Script executed:
Length of output: 0
🏁 Script executed:
Length of output: 66
I need to take a different approach with simpler, more targeted searches. Let me verify the codebase more directly:
Length of output: 27
🏁 Script executed:
Length of output: 27
🏁 Script executed:
Length of output: 568
🏁 Script executed:
Length of output: 27
🏁 Script executed:
Length of output: 0
Let me fix the commands and retry with corrected search patterns:
Length of output: 0
🏁 Script executed:
Length of output: 3057
🏁 Script executed:
Length of output: 42
🏁 Script executed:
Length of output: 1426
🏁 Script executed:
Length of output: 642
Length of output: 0
🏁 Script executed:
Length of output: 0
🏁 Script executed:
Length of output: 0
🏁 Script executed:
Length of output: 903
💡 Result:
Do you want the method signature, usage example, or the source code for ConfigService.updateConfig? I can look it up — shall I search the repo/npm docs now?
💡 Result:
I couldn't find a published @rocket.chat/federation-sdk version 0.2.0 on the public registries. The package appears to have 0.1.x releases (latest listed ~0.1.18); no 0.2.0 release is shown. See registry listings. [1][2]
If you intended to install the latest published release, use:
npm install @rocket.chat/federation-sdk@latest
(Replace @latest with a specific 0.1.x version if you need one.) [1][2]
Sources:
[1] Socket.dev package page for @rocket.chat/federation-sdk (versions list).
[2] Libraries.io npm listing for @rocket.chat/federation-sdk.
Dependency blocker:
@rocket.chat/federation-sdkv0.2.0 does not exist yet.The package appears to have 0.1.x releases; no 0.2.0 release is shown. The code at line 120 calls
services.config.updateConfig(configValues), but this method does not exist in any publicly available version of the SDK. Since the PR description references an unreleased homeserver PR (#289) that implementsupdateConfig, this indicates v0.2.0 is still in development.Action required:
@rocket.chat/federation-sdkv0.2.0 to be released with theupdateConfigmethod, oree/packages/federation-matrix/package.jsononce the SDK is published🧰 Tools
🪛 GitHub Actions: CI
[error] 120-120: TS2339: Property 'updateConfig' does not exist on type 'ConfigService'.
🤖 Prompt for AI Agents
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@coderabbitai, the library exists in the Homeserver project (PR #289), and once it’s reviewed there, we’ll release an update to bump the library version here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.