From 72892775dd682b378ae4091631fd142279c1c3e4 Mon Sep 17 00:00:00 2001 From: MartinSchoeler Date: Tue, 22 Jul 2025 10:08:30 -0300 Subject: [PATCH 1/2] regression: missing font color in App Status Tag --- .../marketplace/AppDetailsPage/tabs/AppStatus/AppStatus.tsx | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/apps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppStatus/AppStatus.tsx b/apps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppStatus/AppStatus.tsx index 93533d58318ad..47ca8c0772b24 100644 --- a/apps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppStatus/AppStatus.tsx +++ b/apps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppStatus/AppStatus.tsx @@ -111,6 +111,10 @@ const AppStatus = ({ app, showStatus = true, isAppDetailsPage, installed, ...pro return Palette.statusColor['status-font-on-warning'].toString(); } + if (status.type === 'danger') { + return Palette.statusColor['status-font-on-danger'].toString(); + } + return Palette.text['font-default'].toString(); }; From 7e442c378287d24ca4c30cdb88be4e7be92f8180 Mon Sep 17 00:00:00 2001 From: MartinSchoeler Date: Tue, 22 Jul 2025 19:00:58 -0300 Subject: [PATCH 2/2] review: use literals instead of accessing Pallete --- .../AppDetailsPage/tabs/AppStatus/AppStatus.tsx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/apps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppStatus/AppStatus.tsx b/apps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppStatus/AppStatus.tsx index 47ca8c0772b24..cb7d32c1f919c 100644 --- a/apps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppStatus/AppStatus.tsx +++ b/apps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppStatus/AppStatus.tsx @@ -1,5 +1,5 @@ import type { App } from '@rocket.chat/core-typings'; -import { Box, Button, Tag, Margins, Icon, Palette } from '@rocket.chat/fuselage'; +import { Box, Button, Tag, Margins, Icon } from '@rocket.chat/fuselage'; import { useSafely } from '@rocket.chat/fuselage-hooks'; import { useRouteParameter, usePermission, useSetModal } from '@rocket.chat/ui-contexts'; import type { ReactElement } from 'react'; @@ -108,14 +108,14 @@ const AppStatus = ({ app, showStatus = true, isAppDetailsPage, installed, ...pro const getStatusFontColor = (status: appStatusSpanResponseProps) => { if (status.type === 'warning') { - return Palette.statusColor['status-font-on-warning'].toString(); + return 'status-font-on-warning'; } if (status.type === 'danger') { - return Palette.statusColor['status-font-on-danger'].toString(); + return 'status-font-on-danger'; } - return Palette.text['font-default'].toString(); + return 'font-default'; }; const handleAppRequestsNumber = (status: appStatusSpanResponseProps) => {