fix: Enterprise settings disabled in `Admin > Settings` despite a license with required modules being present #35790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

ggazzo merged 7 commits into develop from fix/disabledEnterpriseSettings

Apr 17, 2025

.changeset/afraid-boxes-destroy.md

-Original file line number
+Diff line change
@@ -0,0 +1,6 @@
+    ---
+    "@rocket.chat/meteor": patch
+    "@rocket.chat/core-typings": patch
+    ---
+    Fixes an issue in `Admin > Settings` page where sometimes settings guarded by a license module would not be editable despite having the required modules.

-Original file line number
+Diff line change
@@ Expand Up / @@ -295,6 +295,7 @@ export class RocketChatSettingsAdapter { @@
     			i18nLabel: 'Federation_Matrix_max_size_of_public_rooms_users',
     			i18nDescription: 'Federation_Matrix_max_size_of_public_rooms_users_desc',
     			alert: 'Federation_Matrix_max_size_of_public_rooms_users_Alert',
+    			modules: ['federation'],
     			public: true,
     			enterprise: true,
     			invalidValue: false,
@@ Expand Down @@

apps/meteor/server/settings/layout.ts

-Original file line number
+Diff line change
@@ Expand Up / @@ -89,6 +89,7 @@ export const createLayoutSettings = () => @@
     				invalidValue: false,
     				enterprise: true,
     				public: true,
+    				modules: ['hide-watermark'],
     				enableQuery: [
     					{
     						_id: 'Layout_Home_Body',
@@ Expand Down @@

Provide feedback