From 6a6f46c60841329315278af805f837bde7d96fe7 Mon Sep 17 00:00:00 2001 From: Douglas Gubert Date: Wed, 26 Feb 2025 14:39:37 -0300 Subject: [PATCH 1/2] Fix wrong return value on IPreRoomCreateModify event --- packages/apps-engine/src/server/managers/AppListenerManager.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/apps-engine/src/server/managers/AppListenerManager.ts b/packages/apps-engine/src/server/managers/AppListenerManager.ts index 2d6cd25e62ad6..2b862dab0efb6 100644 --- a/packages/apps-engine/src/server/managers/AppListenerManager.ts +++ b/packages/apps-engine/src/server/managers/AppListenerManager.ts @@ -326,6 +326,7 @@ export class AppListenerManager { return !!(lockedEventList && lockedEventList.size); } + /* eslint-disable-next-line complexity */ public async executeListener(int: I, data: IListenerExecutor[I]['args'][0]): Promise { if (this.isEventBlocked(int)) { throw new EssentialAppDisabledException('There is one or more apps that are essential to this event but are disabled'); @@ -794,7 +795,7 @@ export class AppListenerManager { } } - return data; + return room; } private async executePostRoomCreate(data: IRoom): Promise { From 93a61db3c36df0d3256124ccbb2f0fd027cf6f2f Mon Sep 17 00:00:00 2001 From: Douglas Gubert Date: Wed, 26 Feb 2025 14:46:36 -0300 Subject: [PATCH 2/2] Add changeset --- .changeset/pretty-dragons-remain.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .changeset/pretty-dragons-remain.md diff --git a/.changeset/pretty-dragons-remain.md b/.changeset/pretty-dragons-remain.md new file mode 100644 index 0000000000000..aa022f9766e01 --- /dev/null +++ b/.changeset/pretty-dragons-remain.md @@ -0,0 +1,6 @@ +--- +'@rocket.chat/apps-engine': patch +'@rocket.chat/meteor': patch +--- + +Fixes an issue that prevents modifications from being persisted in the IPreRoomCreateModify