fix(apps): room converter errors out when converting livechat room closed by the visitor #35107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

kodiakhq merged 20 commits into develop from fix/apps-room-converter

Feb 18, 2025

.changeset/popular-mugs-try.md

-Original file line number
+Diff line change
@@ -0,0 +1,5 @@
+    ---
+    '@rocket.chat/meteor': patch
+    ---
+    Fixes an issue where the room converter would throw if the room was an omnichannel room that had been closed by the visitor

-Original file line number
+Diff line change
@@ Expand Up / @@ -68,11 +68,18 @@ export class AppRoomsConverter { @@
     		let closedBy;
     		if (room.closedBy) {
-    			const user = await Users.findOneById(room.closedBy.id);
-    			closedBy = {
-    				_id: user._id,
-    				username: user.username,
-    			};
+    			if (room.closer === 'user') {
+    				const user = await Users.findOneById(room.closedBy.id);
+    				closedBy = {
+    					_id: user._id,
+    					username: user.username,
+    				};
+    			} else if (room.closer === 'visitor') {
+    				closedBy = {
+    					_id: v._id,
+    					username: v.username,
+    				};
+    			}
     		}
     		let contactId;
@@ Expand Down @@

Provide feedback