From abeef6176740de9beb2e140d5aee189ae3115e6f Mon Sep 17 00:00:00 2001
From: Hugo Costa <hugocarreiracosta@gmail.com>
Date: Fri, 15 Dec 2023 14:02:52 -0300
Subject: [PATCH] chore: add aria-label to Select Inputs at Engagement
 Dashboard

---
 .../ee/client/components/dashboards/PeriodSelector.tsx | 10 +++++++++-
 .../engagementDashboard/EngagementDashboardPage.tsx    |  7 ++++++-
 .../users/BusiestChatTimesSection.tsx                  |  7 ++++++-
 apps/meteor/packages/rocketchat-i18n/i18n/en.i18n.json |  3 ++-
 4 files changed, 23 insertions(+), 4 deletions(-)

diff --git a/apps/meteor/ee/client/components/dashboards/PeriodSelector.tsx b/apps/meteor/ee/client/components/dashboards/PeriodSelector.tsx
index 7d84a4df62d25..6977e3334f4fb 100644
--- a/apps/meteor/ee/client/components/dashboards/PeriodSelector.tsx
+++ b/apps/meteor/ee/client/components/dashboards/PeriodSelector.tsx
@@ -18,7 +18,15 @@ const PeriodSelector = <TPeriod extends Period['key']>({ periods, value, name, o
 
 	const options = useMemo<[string, string][]>(() => periods.map((period) => [period, t(...getPeriod(period).label)]), [periods, t]);
 
-	return <Select name={name} options={options} value={value} onChange={(value): void => onChange(value as TPeriod)} />;
+	return (
+		<Select
+			name={name}
+			options={options}
+			value={value}
+			onChange={(value): void => onChange(value as TPeriod)}
+			aria-label={t('Select_period')}
+		/>
+	);
 };
 
 export default PeriodSelector;
diff --git a/apps/meteor/ee/client/views/admin/engagementDashboard/EngagementDashboardPage.tsx b/apps/meteor/ee/client/views/admin/engagementDashboard/EngagementDashboardPage.tsx
index 711798dc49072..de40e04dcfcac 100644
--- a/apps/meteor/ee/client/views/admin/engagementDashboard/EngagementDashboardPage.tsx
+++ b/apps/meteor/ee/client/views/admin/engagementDashboard/EngagementDashboardPage.tsx
@@ -35,7 +35,12 @@ const EngagementDashboardPage = ({ tab = 'users', onSelectTab }: EngagementDashb
 	return (
 		<Page background='tint'>
 			<PageHeader title={t('Engagement')}>
-				<Select options={timezoneOptions} value={timezoneId} onChange={(value) => handleTimezoneChange(String(value))} />
+				<Select
+					options={timezoneOptions}
+					value={timezoneId}
+					onChange={(value) => handleTimezoneChange(String(value))}
+					aria-label={t('Default_Timezone_For_Reporting')}
+				/>
 			</PageHeader>
 			<Tabs>
 				<Tabs.Item selected={tab === 'users'} onClick={handleTabClick('users')}>
diff --git a/apps/meteor/ee/client/views/admin/engagementDashboard/users/BusiestChatTimesSection.tsx b/apps/meteor/ee/client/views/admin/engagementDashboard/users/BusiestChatTimesSection.tsx
index de8ebee6dfe3d..f70acde3a8e42 100644
--- a/apps/meteor/ee/client/views/admin/engagementDashboard/users/BusiestChatTimesSection.tsx
+++ b/apps/meteor/ee/client/views/admin/engagementDashboard/users/BusiestChatTimesSection.tsx
@@ -45,7 +45,12 @@ const BusiestChatTimesSection = ({ timezone }: BusiestChatTimesSectionProps): Re
 	return (
 		<>
 			<EngagementDashboardCardFilter>
-				<Select options={timeUnitOptions} value={timeUnit} onChange={(value) => handleTimeUnitChange(String(value))} />
+				<Select
+					options={timeUnitOptions}
+					value={timeUnit}
+					onChange={(value) => handleTimeUnitChange(String(value))}
+					aria-label={t('Select_period')}
+				/>
 			</EngagementDashboardCardFilter>
 			<Content
 				displacement={displacement}
diff --git a/apps/meteor/packages/rocketchat-i18n/i18n/en.i18n.json b/apps/meteor/packages/rocketchat-i18n/i18n/en.i18n.json
index de0e3cfed58eb..25be4b91957a2 100644
--- a/apps/meteor/packages/rocketchat-i18n/i18n/en.i18n.json
+++ b/apps/meteor/packages/rocketchat-i18n/i18n/en.i18n.json
@@ -4643,6 +4643,7 @@
   "Select_atleast_one_channel_to_forward_the_messsage_to": "Select at least one channel to forward the message to",
   "Select_user": "Select user",
   "Select_users": "Select users",
+  "Select_period": "Select period",
   "Selected_agents": "Selected agents",
   "Selected_by_default": "Selected by default",
   "Selected_departments": "Selected Departments",
@@ -6250,4 +6251,4 @@
   "Seat_limit_reached": "Seat limit reached",
   "Seat_limit_reached_Description": "Your workspace reached its contractual seat limit. Buy more seats to add more users.",
   "Buy_more_seats": "Buy more seats"
-}
\ No newline at end of file
+}