Skip to content

[FIX][ENTERPRISE] Race condition on Omnichannel visitor abandoned callback #22413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
renatobecker merged 5 commits into from
Jun 29, 2021
Merged

[FIX][ENTERPRISE] Race condition on Omnichannel visitor abandoned callback #22413

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
52338a9
Fix Visitor Inactivity monitor not working
murtaza98 Jun 18, 2021
517c156
Add comment
murtaza98 Jun 28, 2021
74c0ce3
Merge branch 'develop' into omnichannel/fix-visitor-monitor-not-working
renatobecker Jun 28, 2021
e70e4f5
Fix tslint issue
murtaza98 Jun 28, 2021
3bfe036
Merge branch 'develop' into omnichannel/fix-visitor-monitor-not-working
renatobecker Jun 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ee/app/livechat-enterprise/server/hooks/setPredictedVisitorAbandonmentTime.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,4 @@ callbacks.add('afterSaveMessage', function(message, room) {
setPredictedVisitorAbandonmentTime(room);
}
return message;
}, callbacks.priority.HIGH, 'save-visitor-inactivity');
}, callbacks.priority.MEDIUM, 'save-visitor-inactivity'); // This hook priority should always be less than the priority of hook "save-last-visitor-message-timestamp" bcs, the room.v.lastMessage property set there is being used here for determinting visitor abandonment