-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide "More private groups" when the user has no private groups. #776
Comments
I can look into this! :) |
I kept thinking about the suggested limit and IMHO this would go beyond the issue itself, which was displaying a "useless" UI element. Let me know what you folks think about this suggestion so I can move this further or open a PR later today :) |
@gmsecrieru Agreed. I mean, the optimum solution is to only show the element if there's no longer any room for private chats; for now, it's consistent with channels, i.e. only show it if the list of private groups is > 1. |
@gmsecrieru yeah I think that would maybe be a separate ordeal. It might be kind of nice to limit.. but it could be potentially hard to get right. on a related note. It'd be amazing to paginate the channel lists some how. Both public and private. Can get pretty large. |
@geekgonecrazy I think the current scrolling is fine, but it definitely needs a filter input. :) |
Just noticed that if you have no private groups, you're still given the option of looking for more private groups, which clearly, you won't have:
Probably should only show 'More private groups' once the user has more than a set limit. 3? 5? Not sure what the best limit is.
The text was updated successfully, but these errors were encountered: