Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide "More private groups" when the user has no private groups. #776

Closed
Morgul opened this issue Sep 12, 2015 · 5 comments
Closed

Hide "More private groups" when the user has no private groups. #776

Morgul opened this issue Sep 12, 2015 · 5 comments

Comments

@Morgul
Copy link
Contributor

Morgul commented Sep 12, 2015

Just noticed that if you have no private groups, you're still given the option of looking for more private groups, which clearly, you won't have:

screen shot 2015-09-12 at 12 26 03 pm

Probably should only show 'More private groups' once the user has more than a set limit. 3? 5? Not sure what the best limit is.

@gmsecrieru
Copy link
Contributor

I can look into this! :)

@gmsecrieru
Copy link
Contributor

I kept thinking about the suggested limit and IMHO this would go beyond the issue itself, which was displaying a "useless" UI element.

Let me know what you folks think about this suggestion so I can move this further or open a PR later today :)

@Morgul
Copy link
Contributor Author

Morgul commented Sep 12, 2015

@gmsecrieru Agreed. I mean, the optimum solution is to only show the element if there's no longer any room for private chats; for now, it's consistent with channels, i.e. only show it if the list of private groups is > 1.

@geekgonecrazy
Copy link
Contributor

@gmsecrieru yeah I think that would maybe be a separate ordeal. It might be kind of nice to limit.. but it could be potentially hard to get right.

on a related note. It'd be amazing to paginate the channel lists some how. Both public and private. Can get pretty large.

@Morgul
Copy link
Contributor Author

Morgul commented Sep 12, 2015

@geekgonecrazy I think the current scrolling is fine, but it definitely needs a filter input. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants