-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Providing overrides / white label container via docker volume mounts #540
Comments
Related to #277. The real ingenious part of @geekgonecrazy's approach is that each deployed instance can have a completely different look - configured at deployment time, with assets independent from the build image - without having to customize and re-build and maintain multiple code bases. For those deploying via docker, this can allow one single VPS or bare-metal to host multiple private-labeled instances of Rocket.Chat simultaneously. If these are lightly loaded instances, over provisioning (just like shared hosting) is possible. Our work is to enable more 'customization points', in the core code, using this technique. |
What about use db to store these settings? Maybe the url that respond the favicon can read the settings and look the right file in FS or load from GridFS (maybe we can upload these files in the settings page) |
@rodrigok problem with that is, now the UI depends on the db just to render the page right? Also increasing the load on the db in larger instances. |
@geekgonecrazy If we use only the settings and get the file from FS using the path in settings we don't use DB, just "redirect" the normal behavior. |
ah! I get what you're saying now. So technically I could do something like:
Then in the settings set This would then work great for docker or even other setups. |
Exactly |
It would be great if those theming would also be pushed to mobile apps. So that when an user open a hosted project, it gets logos and colors over. |
@Sing-Li asked me to create this issue.
Pretty much I started with just wanting to be able to override the favicon. So I came up with this snippet below.
So I guess the idea would be that you could override things like this via environment variables.
So things like:
I'm sure several more.
This would allow many instances of this to be spawned up.
In code this would probably be something like:
variable = process.env.favicon || defaultvalue;
The text was updated successfully, but these errors were encountered: