The application GUI crashed when trying to open a file selection dialog from a connected webDav cloud

[Den4ik92]

Description:

The application GUI crashed when trying to open a file selection dialog from a connected webDav cloud

Precondition:

1. Have WebDav Nextcloud (My cloud uses keycloak authentication (optional))
2. Have some files on the cloud

Steps to reproduce:

1. Enable Webdav Integration in settings
2. Add WebDav Nextcloud from message page
3. Click the "More actions" button and select the connected WebDAV server.

Expected behavior:

See dialog with files list

Actual behavior:

Application GUI crashed

Server Setup Information:

• Version of Rocket.Chat Server: 7.2.1
• Operating System: Ubuntu
• Deployment Method: Deploy with Ubuntu
• Number of Running Instances: 1
• NodeJS Version: 20.18.1
• MongoDB Version: 6.0.19

Client Setup Information

• Desktop App or Browser Version
• Operating System: MacOS, Ubuntu, Windows

Additional context

Relevant logs:

• modules.js?hash=32b2…a9a21707818c:125067 Uncaught Error: Objects are not valid as a React child (found: [object Promise]). If you meant to render a collection of children, use an array instead.
• Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in a useEffect cleanup function.

FIX

The problem is in the declaration of the "timeAgo" function (at apps/meteor/client/lib/utils/timeAgo.ts) as an async.
When calling it inside the "WebdavFilePickerTable" component, the application breaks. Solution: remove the declaration of the "timeAgo" function as an async and return a string.