Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Cyrillic Words Highlighting #32584

Open
CyberStranger opened this issue Jun 11, 2024 · 4 comments
Open

Issue with Cyrillic Words Highlighting #32584

CyberStranger opened this issue Jun 11, 2024 · 4 comments

Comments

@CyberStranger
Copy link

Description:

There's an issue with the highlighting functionality for Cyrillic words. When adding Russian words to Preferences > Highlights > Highlights word settings, these words do not get highlighted in the chat if they are not at the beginning of a sentence. This behavior is different from the highlighting of English words, which get highlighted regardless of their position in the sentence.

Steps to reproduce:

  1. Open the Rocket.Chat desktop client.
  2. Navigate to Preferences > Highlights.
  3. Add a word in Russian (e.g., "тест") to the Highlights word list.
  4. Send a message in any chat where the Russian word is not at the beginning of the sentence (e.g., "Это тест сообщения").
  5. Observe that the Russian word is not highlighted in the message.

Expected behavior:

Russian words added to Highlights should be highlighted regardless of their position in the sentence, similar to the behavior for English words.

Actual behavior:

Russian words are only highlighted when they are at the beginning of the sentence.

Server Setup Information:

  • Version of Rocket.Chat Server: 6.8.0
  • Operating System: Linux
  • Deployment Method: docker
  • Number of Running Instances: 20
  • DB Replicaset Oplog: Yes
  • NodeJS Version: 14.21.3
  • MongoDB Version: 5.0.21 / wiredTiger

Client Setup Information

  • Desktop App or Browser Version: Rocket.Chat.Electron 3.9.9, Rocket.Chat.Electron 3.9.15
  • Operating System: Microsoft Windows 10

Additional context

This issue affects users who communicate frequently in Russian or any other language using Cyrillic script, causing an inconsistent user experience. Any help in resolving this issue would be greatly appreciated.
highlights
start_pos
not_start_pos

@reetp
Copy link

reetp commented Jun 12, 2024

Hi and thanks for reporting this.

Can you please test this on the latest versions of server & client?

open.rocket.chat is very latest, or run 6.9 on your own infra.

Use the latest 4.x Electron client, and also test with a browser.

@CyberStranger
Copy link
Author

CyberStranger commented Jun 13, 2024

Hi. I tested on RocketChat Server 6.9.1 and RocketChat.Electron 4.0.0. This bug is also present. Additionally I tested with Google Chrome and Mozilla Firefox. Same behavior

@reetp
Copy link

reetp commented Jun 14, 2024

I have asked if someone can look at this.

Please be patient.

@reetp
Copy link

reetp commented Jun 14, 2024

This has been reported internally as well and is in hand.

It isn't top priority so the fix may take a while.

@Gustrb Gustrb assigned Gustrb and unassigned Gustrb Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants