Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create skeleton manifest.json #2723

Closed
dandv opened this issue Mar 31, 2016 · 3 comments
Closed

Create skeleton manifest.json #2723

dandv opened this issue Mar 31, 2016 · 3 comments
Labels
stat: triaged Issue reviewed and properly tagged type: improvement ui/ux
Milestone
2.0.0

Comments

@dandv
Copy link

dandv commented Mar 31, 2016

When loading https://demo.rocket.chat/channel/general, Chrome attempts to fetch manifest.json:

image

It would also help the PWA effort to have a valid skeleton manifest.json.

Generators:
@engelgabriel engelgabriel added this to the 0.25.0 milestone Mar 31, 2016
@engelgabriel
Copy link
Member

We already have:

https://github.com/RocketChat/Rocket.Chat/blob/develop/public/images/logo/manifest.json

Should we move it to a route like /manifest.json

@engelgabriel
Copy link
Member

We also have the TAG on the <head>

<link rel="manifest" href="images/logo/manifest.json?v=3">

@engelgabriel engelgabriel modified the milestones: 0.25.0, 0.26.0 Apr 4, 2016
@engelgabriel engelgabriel modified the milestones: 0.26.0, 0.27.0 Apr 11, 2016
@marceloschmidt marceloschmidt modified the milestone: 0.27.0 Apr 18, 2016
@Sing-Li Sing-Li added the ui/ux label Jul 18, 2019
@Sing-Li Sing-Li added this to the 1.4.0 milestone Jul 18, 2019
@tassoevan
Copy link
Contributor

The issue seems to not be reproducible anymore.

@tassoevan tassoevan added stat: triaged Issue reviewed and properly tagged and removed Triaged labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stat: triaged Issue reviewed and properly tagged type: improvement ui/ux
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
6 participants
@dandv @Sing-Li @rodrigok @engelgabriel @marceloschmidt @tassoevan