Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression] Can't add retention policy to a channel if there is no global policy for it #11925

Closed
vynmera opened this issue Sep 1, 2018 · 0 comments · Fixed by #11927
Closed

Comments

@vynmera
Copy link
Contributor

vynmera commented Sep 1, 2018

In one of @ggazzo 's commits, the first removed OverrideGlobal switch was readded. This is fine, except when you need to set a per-channel policy in a server without a global policy.
The OverrideGlobal switch only appears when a global policy is set. This would make sense (there is no global policy to override, after all), but it poses an issue.
All subsequent switches (e.g. max age, exclude pinned etc.) require the OverrideGlobal switch to be set. Since there is no global policy, we can't flip that switch, and as such are locked out of interacting with the policy at all.

Turns out it was mostly just due to erroneous templating. Fix is in!

Fix here: #11927

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant