From 367c90eb153976483cd404dcceac6a1a23394bb1 Mon Sep 17 00:00:00 2001 From: dougfabris Date: Wed, 31 Jul 2024 14:01:16 -0300 Subject: [PATCH] fix: missing `exact` in locator --- apps/meteor/client/sidebarv2/header/CreateChannelModal.tsx | 1 - apps/meteor/client/sidebarv2/header/CreateTeamModal.tsx | 1 - apps/meteor/tests/e2e/page-objects/fragments/home-sidenav.ts | 2 +- 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/apps/meteor/client/sidebarv2/header/CreateChannelModal.tsx b/apps/meteor/client/sidebarv2/header/CreateChannelModal.tsx index 9b5f3a8e9e308..38a1df5a5ec8a 100644 --- a/apps/meteor/client/sidebarv2/header/CreateChannelModal.tsx +++ b/apps/meteor/client/sidebarv2/header/CreateChannelModal.tsx @@ -279,7 +279,6 @@ const CreateChannelModal = ({ teamId = '', onClose, reload }: CreateChannelModal - diff --git a/apps/meteor/client/sidebarv2/header/CreateTeamModal.tsx b/apps/meteor/client/sidebarv2/header/CreateTeamModal.tsx index 4c2d01ad1ae53..e907558ce2786 100644 --- a/apps/meteor/client/sidebarv2/header/CreateTeamModal.tsx +++ b/apps/meteor/client/sidebarv2/header/CreateTeamModal.tsx @@ -234,7 +234,6 @@ const CreateTeamModal = ({ onClose }: CreateTeamModalProps) => { - diff --git a/apps/meteor/tests/e2e/page-objects/fragments/home-sidenav.ts b/apps/meteor/tests/e2e/page-objects/fragments/home-sidenav.ts index c71cf70627668..0f17b7ccb5d47 100644 --- a/apps/meteor/tests/e2e/page-objects/fragments/home-sidenav.ts +++ b/apps/meteor/tests/e2e/page-objects/fragments/home-sidenav.ts @@ -10,7 +10,7 @@ export class HomeSidenav { } get advancedSettingsAccordion(): Locator { - return this.page.getByRole('dialog').getByRole('button', { name: 'Advanced settings' }); + return this.page.getByRole('dialog').getByRole('button', { name: 'Advanced settings', exact: true }); } get checkboxPrivateChannel(): Locator {