From 344d9e48627f79b14099821afce4ff86091c3e83 Mon Sep 17 00:00:00 2001 From: Youssef Muhamad Date: Sun, 19 Jul 2020 20:23:10 -0300 Subject: [PATCH 1/4] Improve 2fa visual hierarchy --- app/containers/TwoFactor/styles.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/containers/TwoFactor/styles.js b/app/containers/TwoFactor/styles.js index 36608408acc..4768a6888ee 100644 --- a/app/containers/TwoFactor/styles.js +++ b/app/containers/TwoFactor/styles.js @@ -14,7 +14,8 @@ export default StyleSheet.create({ borderRadius: 4 }, title: { - fontSize: 14, + fontSize: 16, + textAlign: 'center', paddingBottom: 8, ...sharedStyles.textBold }, From 20401e9869a35e6622fa81afb501ecd01fe856a7 Mon Sep 17 00:00:00 2001 From: Youssef Muhamad Date: Sun, 19 Jul 2020 20:26:16 -0300 Subject: [PATCH 2/4] Show 2fa keyboard by scheduling focus method after all interactions --- app/containers/TwoFactor/index.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/containers/TwoFactor/index.js b/app/containers/TwoFactor/index.js index e59ed0c1a6f..011b5e3de56 100644 --- a/app/containers/TwoFactor/index.js +++ b/app/containers/TwoFactor/index.js @@ -1,5 +1,5 @@ import React, { useEffect, useState } from 'react'; -import { View, Text } from 'react-native'; +import { View, Text, InteractionManager } from 'react-native'; import _ from 'lodash'; import PropTypes from 'prop-types'; import { sha256 } from 'js-sha256'; @@ -99,6 +99,7 @@ const TwoFactor = React.memo(({ theme, isMasterDetail }) => { InteractionManager.runAfterInteractions(() => e?.getNativeRef()?.focus())} returnKeyType='send' autoCapitalize='none' onChangeText={setCode} From 67d8bb0ac400010491d16d2ef67a0d7a4d6e4e46 Mon Sep 17 00:00:00 2001 From: Youssef Muhamad Date: Tue, 21 Jul 2020 17:04:28 -0300 Subject: [PATCH 3/4] Remove unrelated styling improvements --- app/containers/TwoFactor/styles.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/app/containers/TwoFactor/styles.js b/app/containers/TwoFactor/styles.js index 4768a6888ee..36608408acc 100644 --- a/app/containers/TwoFactor/styles.js +++ b/app/containers/TwoFactor/styles.js @@ -14,8 +14,7 @@ export default StyleSheet.create({ borderRadius: 4 }, title: { - fontSize: 16, - textAlign: 'center', + fontSize: 14, paddingBottom: 8, ...sharedStyles.textBold }, From f079c99bf8574d558dee22b53c358a64f634a712 Mon Sep 17 00:00:00 2001 From: Youssef Muhamad Date: Tue, 21 Jul 2020 17:24:01 -0300 Subject: [PATCH 4/4] Improve 2fa component title hierarchy --- app/containers/TwoFactor/styles.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/containers/TwoFactor/styles.js b/app/containers/TwoFactor/styles.js index 36608408acc..1c5c789cb49 100644 --- a/app/containers/TwoFactor/styles.js +++ b/app/containers/TwoFactor/styles.js @@ -14,9 +14,10 @@ export default StyleSheet.create({ borderRadius: 4 }, title: { - fontSize: 14, + fontSize: 16, paddingBottom: 8, - ...sharedStyles.textBold + ...sharedStyles.textBold, + ...sharedStyles.textAlignCenter }, subtitle: { fontSize: 14,