Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After closing the app, we aren't able to resume any download after a restart #2489

Closed
Palanikannan1437 opened this issue Aug 26, 2022 · 0 comments · Fixed by #2490
Closed

Comments

@Palanikannan1437
Copy link
Contributor

Describe the bug

If a download is paused and then the app is closed, on reopening the app we aren't
able to resume the download!

  • What operating system and which version - MacOS Monterrey Version 12.5 (21G72)
  • Which version of Rocket.Chat (Server) - 5.0.2
  • Which version of Rocket.Chat.Electron (Electron/Desktop) - 3.8.8

Steps To Reproduce

  1. Start downloading a file
  2. Go to the Download View using the sidebar
  3. Pause the download
  4. Close the App
  5. Re-open the App and do Step 2. again
  6. The Download won't respond/start when you click on resume!

The bug

If we pause a download and close the app, on reopening the app we aren't able to resume the download!

Expected behaviour

On reopening the app, all the downloads would be in a cancelled state instead (except the already completed downloads obviously though) since that's the default behaviour of electron (while closing the app, electron emits a 'cancelled' event) on a DownloadItem but due to lack of time delay between the app closing, the state doesn't get updated properly in our App!

Demo of the above Error

In the below demo I've demonstrated the following:

  • I pause the download
  • I then quit the app
  • I then restart the app and we could then see that all the options like resume and remove from list are unresponsive!
resume-error.mp4
@Palanikannan1437 Palanikannan1437 changed the title After closing the app, we aren't able to Resume the Paused downloads after a restart After closing the app, we aren't able to resume any download after a restart Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant