Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On notification click the window not open on maximized state if it was on it. #2330

Closed
jestrmn opened this issue Mar 4, 2022 · 3 comments · Fixed by #2348
Closed

On notification click the window not open on maximized state if it was on it. #2330

jestrmn opened this issue Mar 4, 2022 · 3 comments · Fixed by #2348
Assignees

Comments

@jestrmn
Copy link

jestrmn commented Mar 4, 2022

Issue with the notification popup in version 3.7.x. When the OS notification appears and Rocket.Chat is not in focus, and the user clicks on the popup, the focus switches to Rocket.Chat and the window becomes windowed instead of staying in the maximized state it was in.

What operating system and which version? Windows 10 21h2
Which version of Rocket.Chat.Electron (Electron/Desktop)? 3.7.8 This last worked as expected in 3.0.7 from what I can tell in testing.
Is there any setting relevant changed? No.

To Reproduce
Steps to reproduce the behavior:

  1. Have Rocket.Chat in a maximized view and minimize it to the taskbar.
  2. Wait for notification from OS that you have a message when Rocket.Chat is minimized.
  3. Click on the popup.
  4. Focus switches to Rocket.Chat and the window is now windowed instead of maximized.

Expected behavior
When focus switches, the window should move to the front maximized if that's the way the user has their app setup.

@mben42
Copy link

mben42 commented Mar 18, 2022

Can confirm this issue still happens in version 3.7.9

@jeanfbrito
Copy link
Collaborator

Thanks for reporting. We already know about this and will take a look in the window states persistence. Seems like a problem with the maximized/fullscreen state.

@jeanfbrito jeanfbrito self-assigned this Mar 18, 2022
@jeanfbrito jeanfbrito changed the title Notification issue On notification click the window not open on maximized state if it was on it. Mar 18, 2022
@mben42
Copy link

mben42 commented Mar 19, 2022

Hi @jeanfbrito. It works, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants