Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme #1

Open
6 tasks done
missxa opened this issue Jul 7, 2018 · 1 comment
Open
6 tasks done

update readme #1

missxa opened this issue Jul 7, 2018 · 1 comment
Assignees

Comments

@missxa
Copy link
Contributor

missxa commented Jul 7, 2018

  • - ROS bridge is not required for you
  • - In a new terminal go to /roboy_snapchat_filter/scripts/ directory and execute rosrun roboy_snapchat_filter snapchat_server.py <- requiring a user to navigate to a specific directory is not ideal. technically you can execute rosrun of your script from anywhere, but because you are dependent on relative paths in your script this is not possible. please change to global paths in your code and it will solve the problem
  • - speech_synthesis launch file? why is it there?
  • - add pictures of the filters that are possible
  • - add exact syntax of a ROS service call to trigger a filter
  • - mention it is a rospackage and depends on roboy_communication_cogntion
@sebo361
Copy link
Collaborator

sebo361 commented Jul 10, 2018

All fixed :)

@sebo361 sebo361 closed this as completed Jul 10, 2018
@sebo361 sebo361 reopened this Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants