-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Suppress some Mac-specific linker warnings." #5362
Conversation
@drake-jenkins-bot mac-clang-bazel-nightly-release please |
@drake-jenkins-bot mac-clang-bazel-experimental please. Review status: 0 of 1 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
+@soonho-tri and +@sammy-tri for both levels of review please. I believe this PR can be merged immediately after the Review status: 0 of 1 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
Reviewed 1 of 1 files at r1. Comments from Reviewable |
Review status: all files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
BTW, I'd like to @david-german-tri to take a look later. Reviewed 1 of 1 files at r1. Comments from Reviewable |
Thanks. This PR is now waiting on the following CI test to pass before it can be merged. https://drake-jenkins.csail.mit.edu/job/mac-clang-bazel-experimental-everything/14/ Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending. Comments from Reviewable |
The mac-clang-bazel-experimental-everything job is still a WIP and depends on a not-yet-merged CI PR. It's status shouldn't hold up this PR. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending. Comments from Reviewable |
Oh, that's great, thanks. What about this build? https://drake-jenkins.csail.mit.edu/job/mac-clang-bazel-experimental/32/ Should the above CI test hold up this PR from being merged? Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending. Comments from Reviewable |
The mac-clang-bazel-experimental is a valid test for this PR (https://drake-jenkins.csail.mit.edu/job/mac-clang-bazel-experimental/31 captured the error) Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending. Comments from Reviewable |
OK thanks. This PR is now blocked on https://drake-jenkins.csail.mit.edu/job/mac-clang-bazel-experimental/32/ passing. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending. Comments from Reviewable |
Passed after 4h42m. |
Reverts #5338
It was discovered that this PR resulted in
gtest
failing to catch exceptions. Specifically, unit tests containingEXPECT_THROW()
orEXPECT_ANY_THROW()
would fail because the exceptions were not being caught bygTest
. Here is an example error:This change is