Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a missing using to get the floating abs on OSX #4956

Merged
merged 2 commits into from
Jan 30, 2017

Conversation

sherm1
Copy link
Member

@sherm1 sherm1 commented Jan 29, 2017

A missing using std::abs caused OSX to choose the integer absolute value rather than floating.

Fixes #4955.


This change is Reviewable

@sherm1
Copy link
Member Author

sherm1 commented Jan 29, 2017

+@liangfok for review please. Can you verify that this works on the platform that failed in #4955?


Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@liangfok
Copy link
Contributor

Sure. Checking now.


Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@liangfok
Copy link
Contributor

@drake-jenkins-bot mac-clang-ninja-experimental please.

@liangfok
Copy link
Contributor

The warning did not appear in the console log of https://drake-jenkins.csail.mit.edu/job/mac-clang-ninja-experimental/232/. I'm still waiting for my local machine to finish building.

@liangfok
Copy link
Contributor

cpplint warning:

Warning	
drake/multibody/benchmarks/cylinder_torque_free_analytical_solution/test/cylinder_torque_free_analytical_solution.cc:116: warning: Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4]

@liangfok
Copy link
Contributor

:lgtm: I confirm that this fixes the warning on both CI and my local machine. Thanks!


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@sherm1
Copy link
Member Author

sherm1 commented Jan 30, 2017

Thanks, Liang!


Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@sherm1 sherm1 merged commit 3914ac7 into RobotLocomotion:master Jan 30, 2017
@sherm1 sherm1 deleted the fix_abs_warning branch January 30, 2017 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants