-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use explicit instead of autoconfigured Bazel CROSSTOOL. #4772
Use explicit instead of autoconfigured Bazel CROSSTOOL. #4772
Conversation
3260d21
to
2ad4fe7
Compare
@drake-jenkins-bot linux-gcc-bazel-experimental please |
@drake-jenkins-bot retest this please |
1 similar comment
@drake-jenkins-bot retest this please |
8075f84
to
9ccb2e7
Compare
-(status: do not merge) -(status: do not review) +@jwnimmer-tri for both levels of review Review status: 0 of 7 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
Most of the LOC in this PR are third_party imports, either from the Bazel source tree, or from the outputs of cc_configure.bzl on our supported platforms: https://github.com/bazelbuild/bazel/blob/master/tools/cpp/cc_configure.bzl Review status: 0 of 7 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
Checkpoint. Reviewed 6 of 7 files at r1. drake/doc/bazel.rst, line 52 at r1 (raw file):
Does this PR need to coincide with a drake-ci configuration change as well, then? tools/third_party/bazel/tools/cpp/osx_cc_wrapper.sh, line 1 at r1 (raw file):
BTW Is this file pristine, or modified in Drake vs Bazel? If the latter, please rebase the commits so that the pristine vendor copy comes it in its own commit, and our diffs are separated out. Comments from Reviewable |
Review status: 6 of 7 files reviewed at latest revision, 2 unresolved discussions. drake/doc/bazel.rst, line 52 at r1 (raw file): Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
Yes, #4920 tools/third_party/bazel/tools/cpp/osx_cc_wrapper.sh, line 1 at r1 (raw file): Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
It's pristine. Comments from Reviewable |
Reviewed 1 of 7 files at r1. tools/CROSSTOOL, line 1 at r1 (raw file):
Please add a comment explaining how to re-run or re-create this step. tools/CROSSTOOL, line 2 at r1 (raw file):
BTW At least some tweaks are marked "specific to Drake". Are they all marked as such? Might be a good idea -- and then if so, explain that marking here. Comments from Reviewable |
Review status: all files reviewed at latest revision, 2 unresolved discussions. Comments from Reviewable |
…-configure. Switch to clang-3.9 by default on Linux.
…r under Bazel on Ubuntu.
9ccb2e7
to
48319e0
Compare
Review status: 6 of 7 files reviewed at latest revision, 2 unresolved discussions. tools/CROSSTOOL, line 1 at r1 (raw file): Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
Done. tools/CROSSTOOL, line 2 at r1 (raw file): Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
Done. Comments from Reviewable |
This change is