[ci] Attempt at more stable macOS GHA brew upgrade issues #259
Conversation
svenevs
left a comment
svenevs
left a comment
There was a problem hiding this comment.
+@BetsyMcPhail for review please.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all discussions resolved, LGTM missing from assignee betsymcphail, platform LGTM missing (waiting on @BetsyMcPhail)
.github/workflows/ci.yml line 60 at r1 (raw file):
sudo rm -rf /Library/Frameworks/Python.framework/ # Run upgrades now to fail-fast (setup scripts do this anyway). brew update && brew upgrade
FYI we are hopeful this will continue to remain functional, we are not sure if the original suggestion of brew install --force python3 && brew unlink python3 && brew unlink python3 && brew link --overwrite python3 will work for us. However, in the future when both 3.10 and 3.11 (for example) update, we may have another hiccup in which case we can try this. It may be that this tells it not to symlink the others?
BetsyMcPhail
left a comment
BetsyMcPhail
left a comment
There was a problem hiding this comment.
CI is happy for now and this seems like the better option.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all discussions resolved, platform LGTM missing (waiting on @svenevs)
svenevs
left a comment
svenevs
left a comment
There was a problem hiding this comment.
+@xuchenhan-tri for platform review per schedule please 🙂 Related slack discussion: https://drakedevelopers.slack.com/archives/C270MN28G/p1675866323159289
Reviewable status: all discussions resolved, LGTM missing from assignee xuchenhan-tri, platform LGTM missing (waiting on @xuchenhan-tri)
xuchen-han
left a comment
xuchen-han
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all discussions resolved, platform LGTM from [xuchenhan-tri] (waiting on @svenevs)
Closes: actions/setup-python#260.
brew update && brew upgrade. Slight variation on their solution, I don't think using thepython3problem will fix it always. Current breakage today is a 3.10 upgrade symlink fail, but in time it can become 3.11. Eventually that package changes?Time consideration: GHA has a lot installed via
brew, uninstallation took 4 minutes. Fixing the symlinks and running upgrade (on today) took 3 minutes 11 seconds.Relates: actions/setup-python#250, actions/setup-python#252, actions/setup-python#257.
This change is