This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 143
Allow functions to be passed to setState #39
Merged
LPGhatguy
merged 4 commits into
Roblox:master
from
AmaranthineCodices:setState-function-variant
Mar 5, 2018
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -326,5 +326,43 @@ return function() | |
|
||
Reconciler.teardown(instance) | ||
end) | ||
|
||
it("should invoke functions to compute a partial state", function() | ||
local TestComponent = Component:extend("TestComponent") | ||
local setStateCallback, getStateCallback | ||
|
||
function TestComponent:init() | ||
setStateCallback = function(newState) | ||
self:setState(newState) | ||
end | ||
|
||
getStateCallback = function() | ||
return self.state | ||
end | ||
|
||
self.state = { | ||
value = 0 | ||
} | ||
end | ||
|
||
function TestComponent:render() | ||
return nil | ||
end | ||
|
||
local element = Core.createElement(TestComponent) | ||
local instance = Reconciler.reify(element) | ||
|
||
expect(getStateCallback().value).to.equal(0) | ||
|
||
setStateCallback(function(props, state) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We might want to assert which argument is which in this function to guard against them being the wrong tables! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done! |
||
return { | ||
value = state.value + 1 | ||
} | ||
end) | ||
|
||
expect(getStateCallback().value).to.equal(1) | ||
|
||
Reconciler.teardown(instance) | ||
end) | ||
end) | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's flip-flop the arguments to match React. I think most cases of functional
setState
are going to depend onstate
more thanprops
anyhow.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense; fixed now!