Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

Add Type Checking API #230

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Add Type Checking API #230

wants to merge 16 commits into from

Commits on Aug 9, 2019

  1. Addresses Roblox#227 

    Added a public API for type checking in Roact

- Added nameOf function to Type to lookup the string name for any Type
- Added TypeMirror module which exposes a subset of types in Type without exposing the internal Roact symbols
- Added Roact.Type and Roact.typeOf to expose a type checking API for external use
    @MisterUncloaked
    MisterUncloaked committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    c5ccab0 View commit details
    Browse the repository at this point in the history

  2. Added comments for TypeMirror.lua and updated docs/changelog with typ… 

    …e info
    @MisterUncloaked
    MisterUncloaked committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    ca0b9e6 View commit details
    Browse the repository at this point in the history

  3. Polishing Type checking docs

    @MisterUncloaked
    MisterUncloaked committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    999d6a2 View commit details
    Browse the repository at this point in the history

  4. Remove Type Checking as a term in docs

    @MisterUncloaked
    MisterUncloaked committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    e5ed458 View commit details
    Browse the repository at this point in the history

  5. Lua fixes in Type documentation

    @MisterUncloaked
    MisterUncloaked committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    1044fd7 View commit details
    Browse the repository at this point in the history

  6. Slightly simpler syntax for Lua code in Type docs

    @MisterUncloaked
    MisterUncloaked committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    3ddc18b View commit details
    Browse the repository at this point in the history

  7. TypeMirror improvements: 

    - removed userdata dance in TypeMirror.lua
- removed redundant checks in TypeMirror.lua
- removed redundant declaration of allowed Roact types
    @MisterUncloaked
    MisterUncloaked committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    e4962cc View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2019

  1. Added Roact.isValidElementType to see if a value has the right type t… 

    …o be passed to Roact.createElement
    @MisterUncloaked
    MisterUncloaked committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    45a3920 View commit details
    Browse the repository at this point in the history

  2. Update documentation for type validation

    @MisterUncloaked
    MisterUncloaked committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    0993ed2 View commit details
    Browse the repository at this point in the history

  3. Add API reference for Roact.isValidElementType

    @MisterUncloaked
    MisterUncloaked committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    57be113 View commit details
    Browse the repository at this point in the history

  4. Polish type-validation.md

    @MisterUncloaked
    MisterUncloaked committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    c5be781 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2019

  1. Rename isValidElementType to isComponent

    @MisterUncloaked
    MisterUncloaked committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    9fc38e8 View commit details
    Browse the repository at this point in the history

  2. Updated changelog to reflect Roact.isComponent

    @MisterUncloaked
    MisterUncloaked committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    0fc8b00 View commit details
    Browse the repository at this point in the history

  3. Simplify test case of typeOf

    @MisterUncloaked
    MisterUncloaked committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    4ea1247 View commit details
    Browse the repository at this point in the history

  4. Fix name for skipped test in isComponent.spec.lua to reflect its nature

    @MisterUncloaked
    MisterUncloaked committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    0d52578 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2019

  1. - typeOf no longer throws 

    - removed Without Type Checking example that used undocumented internals
- removed info blurb about only accepting component classes for additional safety
    @MisterUncloaked
    MisterUncloaked committed Aug 19, 2019
    Configuration menu
    Copy the full SHA
    666d7a9 View commit details
    Browse the repository at this point in the history