-
-
Notifications
You must be signed in to change notification settings - Fork 35
Compatibility fix for Zod 3.25.67 #2758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughA patch version v24.4.1 was added to the changelog, documenting a compatibility fix for Zod version 3.25.67. In the code, the default generic parameter for the Changes
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CHANGELOG.md (1)
5-8: Enhance changelog entry for consistency and clarityTo align with previous entries (e.g., v24.2.2, v24.3.1) and improve discoverability, consider updating the bullet to reference the Zod plugin explicitly and include a hyperlink:
### v24.4.1 - - Compatibility fix for Zod 3.25.67. + - Zod plugin compatibility fix for [Zod v3.25.67](https://github.com/colinhacks/zod/releases/tag/v3.25.67).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (2)
CHANGELOG.md(1 hunks)express-zod-api/src/zod-plugin.ts(2 hunks)
🧰 Additional context used
🧠 Learnings (1)
CHANGELOG.md (1)
undefined
<retrieved_learning>
Learnt from: RobinTail
PR: #2546
File: express-zod-api/tests/form-schema.spec.ts:31-31
Timestamp: 2025-05-27T19:27:13.492Z
Learning: Zod version 3.25.0 and later expose the Zod v4 API through the special import paths "zod/v4" and "zod/v4/core", allowing v4 features like .loose() to be used even when the package.json dependency shows a 3.x version.
</retrieved_learning>
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: build (22.0.0)
- GitHub Check: build (20.x)
- GitHub Check: build (20.9.0)
🔇 Additional comments (2)
express-zod-api/src/zod-plugin.ts (2)
28-28: LGTM: Import addition supports the compatibility fix.The import of
$striptype is correctly added to support the default parameter change in the ZodObject interface.
59-59: ```shell
#!/bin/bashDisplay the first 80 lines to inspect definitions of $ZodObjectConfig and $strip
sed -n '1,80p' express-zod-api/src/zod-plugin.ts
</details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
Summary by CodeRabbit
Documentation
Bug Fixes