Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make blade parameters consistent #12

Open
RobinKa opened this issue Jun 20, 2020 · 1 comment
Open

Make blade parameters consistent #12

RobinKa opened this issue Jun 20, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@RobinKa
Copy link
Owner

RobinKa commented Jun 20, 2020

Right now when passing blades to functions, we either pass blade indices, blade kind or blade names. This should be made more consistent so all functions take the same type of input.

Two possible options:

  • Make everything take blade indices, provide functions to easily convert from kind or name to index
  • Create a new data structure that can hold one of the three and make all functions accept this data structure
@RobinKa RobinKa added the enhancement New feature or request label Jun 20, 2020
@RobinKa
Copy link
Owner Author

RobinKa commented Jun 21, 2020

Made select_blades and keep_blades take blade indices instead of names in 26ecef3 and added functions taking names select_blades_with_name and keep_blades_with_name with the old behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant