Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Analytics used #6

Open
troskop opened this issue Jan 6, 2016 · 3 comments
Open

Google Analytics used #6

troskop opened this issue Jan 6, 2016 · 3 comments

Comments

@troskop
Copy link

troskop commented Jan 6, 2016

Hi,
your App seems to use Google Analytics. [https://github.com/RobSpectre/Trump-Filter/blob/master/js/analytics.js]
According to EU-Law you are not allowed to use it unless you inform the user about this.
Even the description on the Chrome Webstore [https://chrome.google.com/webstore/detail/trump-filter/lhondapiaknegjpellpodegmeonigjic] has no annotation about this.

Moreover, you have to remove the IP of the user when using analytics.

ga('set', 'anonymizeIp', true);

@gaelrottier
Copy link

Since this issue seems not to be resolved, i've reported it to the Google team.

@seemly
Copy link
Contributor

seemly commented Aug 27, 2016

Wow. It actually took longer to write that initial post than to do a pull request.

Given; you (personally) can't update the description of the extension in the Chrome Webstore, but still... A helpful nudge to get the change in motion is in the spirit of the open source community.

Pull request made, with a suggestion to update developer dashboard description for extension:
#11

@dkarter
Copy link

dkarter commented Nov 16, 2016

This is not enough. This extension might leak sensitive information such as password reset links, auth tokens etc. It should not use google analytics or send any web traffic outside the user's browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants