Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

current-section-time and total-time don't add up...? #60

Open
tony-kerz opened this issue May 28, 2017 · 5 comments
Open

current-section-time and total-time don't add up...? #60

tony-kerz opened this issue May 28, 2017 · 5 comments
Assignees
Labels

Comments

@tony-kerz
Copy link

tony-kerz commented May 28, 2017

os: osx 10.11.6
version: 1.2.1

screen shot 2017-05-28 at 9 45 55 am

this was dan's espresso recipe where all sections are in blocks of 30s...

@int3ll3ct
Copy link
Collaborator

Hello Tony, is the issue that there seems to be an offset in the total time on the order of 8 seconds over a six minute window, compared to the mathematical sum of the step times in the recipe?

@int3ll3ct
Copy link
Collaborator

Reading through the code, I think there's one extra second tacked on to every recipe step, looks like a slight logic error. It is in the freshroastsr700 driver code in the timer process. Does that type of offset match with your observations?

@tony-kerz
Copy link
Author

hi @int3ll3ct thanks for looking into this. yes, that sounds about right. ☕️

@int3ll3ct
Copy link
Collaborator

Tony, since this doesn't really affect functionality, I will address this in version 1.3.

@tony-kerz
Copy link
Author

thanks @int3ll3ct !

@int3ll3ct int3ll3ct self-assigned this Oct 15, 2017
@int3ll3ct int3ll3ct added the bug label Oct 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants