Skip to content
This repository has been archived by the owner on Jun 8, 2023. It is now read-only.

✨ Split signals into triggers and guards #236

Open
Rikj000 opened this issue Jan 17, 2022 · 4 comments · May be fixed by #247
Open

✨ Split signals into triggers and guards #236

Rikj000 opened this issue Jan 17, 2022 · 4 comments · May be fixed by #247
Assignees
@Rikj000 @raftersvk
Labels
Feature - Enhancement Update or improvement to existing feature Feature - New New feature or pull request In Progress This is being worked on
Milestone
v1.0.0

Comments

@Rikj000
Copy link
Owner

Rikj000 commented Jan 17, 2022

In the current MoniGoMani implementation we have:

  • buy_signals
  • sell_signals

However we currently do not separate:

  • buy_triggers & sell_triggers (Signals that only fire off once / for a single candle, e.g. If X crossed above Y)
  • buy_guards & sell_guards (Signals that fire off for a period of time / for multiple candles, e.g. if X is above Y)

@raftersvk is currently working on this on his separation-of-signals-into-triggers-and-guards branch,
and it was already showing promising results!
@Rikj000 Rikj000 added Feature - Enhancement Update or improvement to existing feature In Progress This is being worked on labels Jan 17, 2022
@Rikj000 Rikj000 added the Feature - New New feature or pull request label Jan 17, 2022
@Rikj000
Copy link
Owner Author

Rikj000 commented Jan 17, 2022

Linking to issue: #237

@Rikj000 Rikj000 mentioned this issue Jan 17, 2022
Open
@Rikj000 Rikj000 added this to the v1.0.0 milestone Jan 17, 2022
@raftersvk
Copy link
Contributor

check this #247

@Rikj000 Rikj000 linked a pull request Jan 30, 2022 that will close this issue
✨ Split signals into triggers and guards #247
Open
@ghost
Copy link

ghost commented Feb 18, 2022

Why need to separate?

@raftersvk
Copy link
Contributor

by splitting indicators in regards to their nature, we think we will get more precise triggering of buy and sell signals.
so far tests are proving the mechanism is good

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Rikj000 Rikj000

@raftersvk raftersvk

Labels
Feature - Enhancement Update or improvement to existing feature Feature - New New feature or pull request In Progress This is being worked on
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

✨ Split signals into triggers and guards raftersvk/MoniGoMani_raftersvk
2 participants
@Rikj000 @raftersvk