Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wayland: Yet another key repeat issue #207

Closed
simnalamburt opened this issue Feb 5, 2021 · 4 comments · Fixed by #214
Closed

wayland: Yet another key repeat issue #207

simnalamburt opened this issue Feb 5, 2021 · 4 comments · Fixed by #214
Labels
bug Something isn't working S-Blocking Wait for external issues T-Wayland

Comments

@simnalamburt
Copy link
Contributor

simnalamburt commented Feb 5, 2021

image

(56 is Alt, 2 is 1. There's no release event)

In some cases, virtual-keyboard sends only Press event without Release event. Then, user may experience yet another unwanted key repeat issue.

How to reproduce

  1. Turn on firefox
  2. Create two tab
  3. On first tab, turn on the Discord app and focus the message input DOM.
  4. On second tab, focus the URL bar.
  5. Type Alt+1

Expected behavior: Firefox switch to the first tab, and nothing happen
Actual behavior: Firefox switch to the first tab, and types 1 infinitely

This is because firefox never received release event of Alt and 1.

NOTE: This issue is NOT fixed by #206.

@Riey Riey added bug Something isn't working S-Blocking Wait for external issues T-Wayland labels Feb 6, 2021
@Riey
Copy link
Owner

Riey commented Feb 6, 2021

virtual-keyboard sends only Press event without Release event.

Is this screenshot is client side log?

@simnalamburt
Copy link
Contributor Author

virtual-keyboard sends only Press event without Release event.

Is this screenshot is client side log?

That is the trace of kime-wayland sending events to the virtual keyboard.

@Riey
Copy link
Owner

Riey commented Feb 6, 2021

Then it seems compositor doesn't send release event because all release events just bypassed into virtual keyboard

@Riey
Copy link
Owner

Riey commented Feb 6, 2021

I can't test reproduce this can you try this patch? https://github.com/Riey/kime/tree/always-grab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working S-Blocking Wait for external issues T-Wayland
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants