-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net 9 Support #5022
Comments
Hear hear. There are also 106 open pull requests. That's not a great motivation to add more. Yet, NSwag is still the best tool to generate code from OpenAPI, far superior than Kiota. It's disheartening to see even the low hanging fruit is left to rot. |
Seeing that the last commit is 4 months ago, I have a big feeling this project is slowly dying. I do hope that we get .NET 9 support soon though. But yeah, my hopes are sinking :( |
The net8 upgrade was quite rough. Let's hope net9 is smoother. |
Just.. now noticed, that although complete solution is already switched to net9, nswag executes as part of build (I have it as custom msbuild task in CSPROJ) and regenerates clients as expected. (on computer, both sdks are installed). Regardless of that, I am considering switch to native Microsoft.OpenApi / Kiota as part of update to .NET 9 for these API client generation stuff). |
Maintainer here, will add .NET 9 support in the next days. Really need to do a feature gap analysis of new OpenAPI support and NSwag and then see what the next steps are.. motivation is not very high knowing that NSwag essentially has to compete with MS or slowly die.. |
Hey @RicoSuter, Allow me to share my thoughts on this topic. First of all The Thoughts on NSwag's Future Focus
Streamlining the Project I hope these thoughts don’t appear presumptuous. Thanks again for all your work on NSwag! |
@xC0dex thanks for your reply. I also think this is the way forward, e.g. start with NSwag.Extensions (.NET 9 only and provide missing features as extensions) to ensure that we can quickly migrate to MS impl for spec generation and focus on the code generators only long-term. I'm just a bit afraid that a lot of things are not (correctly) implemented yet (tuples, inheritance, nullable, etc.). @lahma thanks for the PR, just wanted to start. |
@RicoSuter I’m glad you share this idea! I’d be happy to contribute and help out. |
.NET 9 support added with v14.2.0, now testing against real-world projects... please report problems here. |
@RicoSuter I updated NSwag.MSBuild to 14.2.0.0 and running am running:
Output gives:
I don't have a reference to it (still digging), the only reference I have is to: Include="NSwag.AspNetCore" Version="14.2.0" . Could this be from the tooling? |
@winromulus can you run |
Found the issue (local nuget cache). All good, all client and build tools ported. Thank you very much @RicoSuter ! |
Can also confirm my SLN with 300+ projects and 10+ NSwag.Build based project successfully migrated (other NSwag unrelated problems remain :-)). |
Upgraded one of 2 nontrivial projects here, and all is well. |
Very well said, and I completely agree. @RicoSuter: We use the client generation functionality in nswag heavily, and I don't see that changing with the .NET 9 OpenApi enhancements. To help keep your motivation up, and to help keep pushing NSwag forward while you streamline the focus, maybe you should require PRs to indicate if they're for the focus areas such as client generation (e.g. #4994), so that you can more easily identify those in the pool of open PRs you receive and use those to help move the unique value that nswag still provides forward with less effort. |
Hi, is there a way we could get an updated tutorial on how to add this to a dotnet 9 web api project and generate a client or maybe one client per controller? |
Hi,
Any chance of getting a NSwagExe_Net90 version soon? (even without any other changes).
Currently we have to install .net 8 in the docker images in order to produce the client which adds a lot of build time.
I couldn't find an issue for this or something mentioning .net 9 so I opened this one. Please feel free to close and link to an existing issue if there is one.
Thanks!
The text was updated successfully, but these errors were encountered: