Compiler errors in generated client when property name matches namespace of Json library

[PolarbearDK]

You get compile errors when you consume a service that has a property called Newtonsoft.
It will generate the following code:

[Newtonsoft.Json.JsonProperty("newtonsoft", Required = Newtonsoft.Json.Required.DisallowNull, NullValueHandling = Newtonsoft.Json.NullValueHandling.Ignore)]
public Supported Newtonsoft { get; set; }

Compiler error:
CS0120 An object reference is required for the non-static field, method, or property 'BreakOpenApiModel.Newtonsoft'

This should be an easy fix: Just prefix with global:: to fix it:

[Newtonsoft.Json.JsonProperty("newtonsoft", Required = global::Newtonsoft.Json.Required.DisallowNull, NullValueHandling = global::Newtonsoft.Json.NullValueHandling.Ignore)]
public Supported Newtonsoft { get; set; }

If you switch to System.Text.Json then a property named System will cause similar problems.

Sample application that demonstrates the problem: github.com/PolarbearDK/OpenApiTest

I have previously mentioned this in #2243

[lahma]

Maybe you could submit a PR to fix the problem?

[PolarbearDK]

Yeah! Great idea.
I tried, but I can't seem to find the responsible code.
I think it is somewhere in NJsonSchema.CodeGeneration.CSharp.Models.PropertyModel but I'm not sure.

[lahma]

Maybe this? It's also referenced from Class.liquid so it might need global qualification too.

https://github.com/RicoSuter/NJsonSchema/blob/63ee6152e9819596e9c7158a9ac634a96f73b2e9/src/NJsonSchema.CodeGeneration.CSharp/Models/PropertyModel.cs#L80C1-L108

[aunikitin]

Hello, faced with it on 13.20.0

And I failed to find source for this. Link upper doesn't lead to master branch. On the master, there's no mention of this attributes. For now I switched to Newtonsoft serialization

[aunikitin]

@RicoSuter hello, can you give a hint, how to fix this problem?

[franklixuefei]

Hi,
I'm hitting this too after exposeJsonSerializerSettings is turned on: