Skip to content

Commit bcd8029

Browse files
authored
bug: Fix install from source will lose version information (tensorchord#1024)
* fix Signed-off-by: Jinjing.Zhou <[email protected]> * lint Signed-off-by: Jinjing.Zhou <[email protected]> * lint Signed-off-by: Jinjing.Zhou <[email protected]> * add Signed-off-by: Jinjing.Zhou <[email protected]> * fix Signed-off-by: Jinjing.Zhou <[email protected]> * fix Signed-off-by: Jinjing.Zhou <[email protected]> * fix Signed-off-by: Jinjing.Zhou <[email protected]> Signed-off-by: Jinjing.Zhou <[email protected]>
1 parent a58197c commit bcd8029

File tree

4 files changed

+13
-2
lines changed

4 files changed

+13
-2
lines changed

.gitignore

+1
Original file line numberDiff line numberDiff line change
@@ -65,5 +65,6 @@ share/python-wheels/
6565
.installed.cfg
6666
*.egg
6767
MANIFEST
68+
.GIT_TAG_INFO
6869

6970
test.tar

MANIFEST.in

+1
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ include Makefile
44
include .goreleaser.yaml .goreleaser/*.Dockerfile
55
include pkg/* cmd/*
66
include go.mod go.sum
7+
include .GIT_TAG_INFO
78
prune examples
89
prune docs
910
prune .github

Makefile

+2-1
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ BUILD_DIR := ./build
7171
VERSION ?= $(shell git describe --match 'v[0-9]*' --always --tags --abbrev=0)
7272
BUILD_DATE=$(shell date -u +'%Y-%m-%dT%H:%M:%SZ')
7373
GIT_COMMIT=$(shell git rev-parse HEAD)
74-
GIT_TAG=$(shell if [ -z "`git status --porcelain`" ]; then git describe --exact-match --tags HEAD 2>/dev/null; fi)
74+
GIT_TAG ?= $(shell if [ -z "`git status --porcelain`" ]; then git describe --exact-match --tags HEAD 2>/dev/null; fi)
7575
GIT_TREE_STATE=$(shell if [ -z "`git status --porcelain`" ]; then echo "clean" ; else echo "dirty"; fi)
7676
GITSHA ?= $(shell git rev-parse --short HEAD)
7777
GIT_LATEST_TAG ?= $(shell git describe --tags --abbrev=0)
@@ -110,6 +110,7 @@ build-release:
110110
-X $(ROOT)/pkg/version.gitTag=$(GIT_TAG)" \
111111
$(CMD_DIR)/$${target}; \
112112
done
113+
@[[ ! -z "$(GIT_TAG)" ]] && echo "$(GIT_TAG)" > .GIT_TAG_INFO
113114

114115
help: ## Display this help
115116
@awk 'BEGIN {FS = ":.*##"; printf "\nUsage:\n make \033[36m<target>\033[0m\n"} /^[a-zA-Z0-9_-]+:.*?##/ { printf " \033[36m%-15s\033[0m %s\n", $$1, $$2 } /^##@/ { printf "\n\033[1m%s\033[0m\n", substr($$0, 5) } ' $(MAKEFILE_LIST)

setup.py

+9-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,15 @@
2626
def build_envd_if_not_found():
2727
if not os.path.exists("bin/envd"):
2828
logging.info("envd not found. Build from scratch")
29-
errno = subprocess.call(["make", "build-release"])
29+
try:
30+
with open(".GIT_TAG_INFO") as f:
31+
logging.info("Use build_tag from envd._version")
32+
tag = f.read().strip()
33+
errno = subprocess.call(
34+
["make", "build-release", "GIT_TAG={}".format(tag)]
35+
)
36+
except:
37+
errno = subprocess.call(["make", "build-release"])
3038
assert errno == 0, "Failed to build envd"
3139

3240

0 commit comments

Comments
 (0)