From 1871b2cdf8499567d98cf50f6481e5e84e34ceb4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=F0=9F=8E=A7=20RicherTunes=20=F0=9F=8E=A7?=
 <xfear26@hotmail.com>
Date: Fri, 13 Feb 2026 09:27:42 -0500
Subject: [PATCH] chore(deps): pin FluentAssertions to 6.12.0 permanently
 (license no-go)

FA v8+ requires Xceed commercial license ($130/dev/year). v7.x remains
Apache 2.0 but has API renames with no functional benefit. v6.12.0 is
the last MIT-licensed release and the API is stable for our test suite.

- Add dependabot ignore rule to prevent future FA bump PRs
- Remove FA from test-dependencies group (ignored packages don't group)
- Document license rationale in Directory.Packages.props comment

Closes #401 decision: stay on 6.12.0 indefinitely.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
---
 .github/dependabot.yml   | 3 ++-
 Directory.Packages.props | 5 ++++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/.github/dependabot.yml b/.github/dependabot.yml
index 1e866fc4..00915084 100644
--- a/.github/dependabot.yml
+++ b/.github/dependabot.yml
@@ -29,7 +29,6 @@ updates:
           - "*Test*"
           - "Moq"
           - "xunit*"
-          - "FluentAssertions"
     # Critical: Don't update Lidarr-specific dependencies
     ignore:
       - dependency-name: "Newtonsoft.Json"
@@ -38,6 +37,8 @@ updates:
         # Keep aligned with Lidarr's NLog version
       - dependency-name: "FluentValidation"
         versions: [">11.0.0"]  # Match Lidarr's version
+      - dependency-name: "FluentAssertions"
+        versions: [">6.12.0"]  # v7+ Apache 2.0, v8+ commercial license — stay on 6.12.0 (MIT)
 
   # Monitor GitHub Actions
   - package-ecosystem: "github-actions"
diff --git a/Directory.Packages.props b/Directory.Packages.props
index c24ffef5..98035460 100644
--- a/Directory.Packages.props
+++ b/Directory.Packages.props
@@ -33,7 +33,10 @@
     <PackageVersion Include="xunit.runner.visualstudio" Version="3.0.2" />
     <PackageVersion Include="coverlet.collector" Version="6.0.4" />
     <PackageVersion Include="Moq" Version="4.20.72" />
-    <!-- FluentAssertions pinned to 6.12.0 (MIT). 7.x+ requires commercial license. -->
+    <!-- FluentAssertions pinned to 6.12.0 (MIT, last free version).
+         v7.x = Apache 2.0 (free), v8.x+ = Xceed commercial license ($130/dev/year).
+         Decision: stay on 6.12.0 indefinitely — no license cost, API is stable.
+         See: https://www.infoq.com/news/2025/01/fluent-assertions-v8-license/ -->
     <PackageVersion Include="FluentAssertions" Version="6.12.0" />
     <PackageVersion Include="Bogus" Version="35.6.5" />
     <!-- Build Tools -->