Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PhotoStudio use less real time to generate a photo at low FPS #3634

Open
84634E1A607A opened this issue Jul 31, 2022 · 3 comments
Open

Comments

@84634E1A607A
Copy link
Contributor

It now takes 9 frames to take a photo. When framerate is low it takes even more than a second.

@hhyyrylainen hhyyrylainen changed the title Make PhotoStudio use less time to generate a photo Make PhotoStudio use less real time to generate a photo at low FPS Jul 31, 2022
@hhyyrylainen
Copy link
Member

The only solution I see is making the photostudio either track the time it is using per frame and do more work up to a limit or make it detect lower FPS to do more work per frame. Otherwise the PhotoStudio will cause lag spikes and destroy frame time consistency which is about the worst thing it could do.

If #3625 is done with a background thread approach this will be solved as well. But if the game is already struggling with FPS adding more CPU load might reduce the FPS even further.

@84634E1A607A
Copy link
Contributor Author

84634E1A607A commented Jul 31, 2022

https://pastebin.com/7H7dfvLx

CaptureImage and Save takes a little longer. (I'm running LoadScene and InstanceScene sync)

@hhyyrylainen
Copy link
Member

Scene load will take potentially a lot of time if the scene is one that has not been loaded before because the scene load needs to load up any resources the scene has (if the resources have not been loaded already).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backburner
Development

No branches or pull requests

2 participants