Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

See if changing rendering mode to multi-threaded improves things #2273

Closed
hhyyrylainen opened this issue May 29, 2021 · 3 comments · Fixed by #2301
Closed

See if changing rendering mode to multi-threaded improves things #2273

hhyyrylainen opened this issue May 29, 2021 · 3 comments · Fixed by #2301

Comments

@hhyyrylainen
Copy link
Member

Currently the render mode is set to single-safe, though I think because of that we might have at least one crash: #2078

So I think we should try setting the render mode to multithreaded, if it improves performance that would be a plus as well. If it doesn't break anything, I think it would be worth it to change to it anyway.

@84634E1A607A
Copy link
Contributor

I think it does improve things.

https://1drv.ms/u/s!AmQa4DeAoN8FlXnMeaXfpBmB5gnm?e=jDNssA

@84634E1A607A
Copy link
Contributor

And I haven't found any issues yet.

@hhyyrylainen
Copy link
Member Author

Thanks for testing.this
I made a PR to make it easier for other people to test this as well. On my computer I didn't notice any real FPS improvement, but I also don't think I experienced the jitter that the Godot editor tooltip warns is possible in multithreaded mode.

#2301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants