Try to fix Bathypelagic Background #5766
Conversation
|
We are currently in feature freeze until the next release. |
|
That shouldn't really have an effect as the detect option only triggers in the godot editor when you use the texture in a way that warrants different options, it will auto-apply those. And once detected it turns off the autodetection, which is probably why the other backgrounds have the property unset. |
|
All the other ones have the property on. These are the only ones that didn't. |
|
Probably what happened is that for these backgrounds they were used in the godot editor to try something which triggered the 3D detection, messing up their import settings and turning the detection off. Then when that was noticed the import settings were fixed but 3D detection was not put on because that's going to do totally the wrong thing with these backgrounds as these are meant for a 2D effect kind of thing. At least that's my understanding that these "detect 3D" options don't impact anything outside the Godot editor whatsoever, so these changes shouldn't be able to do anything, other than set up a landmine for if someone accidentally does something in the Godot editor that triggers the detection and causes the import settings to change to unsuitable ones. Edit: here's the documentation from Godot:
So yeah, this PR shouldn't be able to affect anything... |
|
I'll close this PR for now as I don't think this should affect anything. If I'm wrong absolutely reopen this and let me know. |
Brief Description of What This PR Does
I was not able to replicate the issue with a horizontal line appearing on the bathypelagic patch background, but I noticed that the only patch backgrounds not set to detect_3d/compress_to=1 were for Bathypelagic and Vents. Hopefully this fixes the issue.
(I also checked the texture and found no issues with it.)
Related Issues
Hopefully closes #1265
Progress Checklist
Note: before starting this checklist the PR should be marked as non-draft.
break existing features:
https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
(this is important as to not waste the time of Thrive team
members reviewing this PR)
styleguide.
Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.