Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local cache is not used for "page level" queries #45

Closed
FINDarkside opened this issue Feb 17, 2022 · 2 comments
Closed

Local cache is not used for "page level" queries #45

FINDarkside opened this issue Feb 17, 2022 · 2 comments

Comments

@FINDarkside
Copy link
Contributor

FINDarkside commented Feb 17, 2022 •
edited
Loading

Somewhat relevant: #41 (comment)

I tried to work around the shallow routing issue by just not using shallow routing. But I've ran into an issue where cache is not used at all when the page level query is ran. It's reproducible in the example app as well, even if you update relay-nextjs to 0.6.0.
@FINDarkside
Copy link
Contributor Author

FINDarkside commented Feb 17, 2022 •
edited
Loading

Lol my bad, it is in fact using cache, it's just using store-and-network fetch strategy. 🤦‍♂️

This is probably something that should be configurable. I'll make a PR if it becomes relevant for us.

@rrdelaney
Copy link
Contributor

Would gladly accept a PR to make that configurable 😄 The reason it's currently set to store-and-network is that's what we found to be the most sensible default in our app.

@FINDarkside FINDarkside mentioned this issue Aug 16, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rrdelaney @FINDarkside