Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GBA core is missing some memory in Integration. #19

Closed
GameDragon2k opened this issue Apr 30, 2018 · 3 comments
Closed

GBA core is missing some memory in Integration. #19

GameDragon2k opened this issue Apr 30, 2018 · 3 comments
Labels
bug Something isn't working

Comments

@GameDragon2k
Copy link

I took a quick glance and I noticed that there are two sets of memory ranges being installed in the same bank with RA_InstallMemoryBank. These should be installed in separate banks.

for (unsigned i = 0; i < mmap->num_descriptors; i++)
{
if (mmap->descriptors[i].start == 0x03000000U)
{
data = mmap->descriptors[i].ptr;
size = mmap->descriptors[i].len;
registerMemoryRegion(data, size);
RA_InstallMemoryBank(0, (void*)::memoryRead, (void*)::memoryWrite, size);
_logger.printf(RETRO_LOG_INFO, "Installed %7zu bytes at 0x%08x", size, data);
}
else if (mmap->descriptors[i].start == 0x02000000U)
{
data = mmap->descriptors[i].ptr;
size = mmap->descriptors[i].len;
registerMemoryRegion(data, size);
RA_InstallMemoryBank(0, (void*)::memoryRead, (void*)::memoryWrite, size);
_logger.printf(RETRO_LOG_INFO, "Installed %7zu bytes at 0x%08x", size, data);

@leiradel leiradel added the bug Something isn't working label May 1, 2018
@leiradel
Copy link
Contributor

leiradel commented May 1, 2018

Should WRAM be bank 0 and IRAM bank 1 or the other way around?

@GameDragon2k
Copy link
Author

GameDragon2k commented May 1, 2018

Other way around. IRAM first, then WRAM.

@leiradel
Copy link
Contributor

leiradel commented May 1, 2018

Fixed in 1.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants