-
Notifications
You must be signed in to change notification settings - Fork 3
fix: pagination #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pagination #106
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the WalkthroughThis pull request involves updating several dependencies and devDependencies in the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (2)
package.json(2 hunks)pages/create-invoice.tsx(1 hunks)
🧰 Additional context used
🪛 GitHub Actions: Build
package.json
[error] Package versions mismatch between package.json and package-lock.json for multiple dependencies: @requestnetwork/create-invoice-form (0.12.3 vs 0.12.2), @requestnetwork/invoice-dashboard (0.15.0 vs 0.14.0), @requestnetwork/single-invoice (0.1.2 vs 0.1.1), @requestnetwork/data-format (0.19.8 vs 0.19.7), @requestnetwork/payment-processor (0.55.0 vs 0.54.0), @hinkal/common (0.2.9 vs 0.2.7)
[warning] Peer dependency conflict: tweetnacl-util version mismatch. @lit-protocol/[email protected] requires tweetnacl-util@^0.13.3 but found [email protected]
🔇 Additional comments (1)
pages/create-invoice.tsx (1)
26-26: Add usage note for the newsingleInvoicePathprop.
This newly introduced prop looks straightforward. However, ensure the associated logic in@requestnetwork/create-invoice-formcorrectly interprets “/” and doesn’t cause unintended dispatch to the root path if the user expects a different behavior (e.g., from a subdirectory or local path).
Problem
Dashboard was loading all the requests before pagination which could make it very slow for encrypted requests.
Changes
Update version of the web components and Request Network SDK to include new pagination to dashboard.
Summary by CodeRabbit
Dependency Updates
Component Changes
singleInvoicePathprop to CreateInvoiceForm component