[#387] Remove "SwagEdit" references from validation error and warning… #388
Conversation
| @@ -22,7 +22,7 @@ error_additional_properties_not_allowed = object has properties %s which are not | |||
| error_required_properties = object has missing required properties %s | |||
| error_duplicate_keys = Duplicate key: the object has more than one property named %s | |||
| error_cannot_read_content = Unable to read content. It may be invalid YAML | |||
| error_missing_reference= Invalid Reference - SwagEdit was unable to resolve the reference. \n\ | |||
| error_missing_reference= Invalid Reference - KaiZen Editor was unable to resolve the reference. \n\ | |||
There was a problem hiding this comment.
This i18n binding is not used in the editor code, I only found usages in ReferenceValidatorTest. We can remove it to avoid code duplication and replace messages in tests with the messages defined in the core plugin.
| @@ -22,7 +22,7 @@ error_additional_properties_not_allowed = object has properties %s which are not | |||
| error_required_properties = object has missing required properties %s | |||
| error_duplicate_keys = Duplicate key: the object has more than one property named %s | |||
| error_cannot_read_content = Unable to read content. It may be invalid YAML | |||
| error_missing_reference= Invalid Reference - SwagEdit was unable to resolve the reference. \n\ | |||
There was a problem hiding this comment.
The same here, it's only used in tests, we can eliminate it.
| @@ -9,7 +9,7 @@ | |||
| # ModelSolv, Inc. - initial API and implementation and/or initial documentation | |||
| ############################################################################### | |||
|
|
|||
| error_missing_reference= Invalid Reference - SwagEdit was unable to resolve the reference. \n\ | |||
| error_missing_reference= Invalid Reference - KaiZen Editor was unable to resolve the reference. \n\ | |||
There was a problem hiding this comment.
This message is actually used by Validator, but we should change phrasing to Unable to resolve the reference
See description:
"Unable to resolve the reference" is fine. We don't need to say "KaiZen OpenAPI Editor is unable to resolve the reference."
|
I found several other entries in GUI, e.g. this one (specified in plugin.xml): I recommend doing a case-sensitive search for |
|
@ghillairet , I left several suggestions in this PR. Please address them when you have the time 😓 |
|
@tfesenko I think I removed them all now. |
| @@ -9,7 +9,7 @@ | |||
| # ModelSolv, Inc. - initial API and implementation and/or initial documentation | |||
| ############################################################################### | |||
|
|
|||
| error_missing_reference= Invalid Reference - KaiZen Editor was unable to resolve the reference. \n\ | |||
| error_missing_reference= Invalid Reference - Unable to resolve the reference. \n\ | |||
| @@ -13,27 +13,3 @@ swagedit_wizard_title = Swagger Spec | |||
|
|
|||
| # wizard | |||
| swagedit_wizard_description = This wizard creates a new Swagger Spec in YAML format, which can be opened in KaiZen Editor. | |||
|
Looks good:
Note that |
… messages