Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAPI v3: code assist for security scheme, operationId and operationRef #332

Merged
merged 6 commits into from
May 26, 2017

Conversation

ghillairet
Copy link
Member

This is a PR for the following issues:

This PR overlaps with PR #319, this last one should be discarded and this one should be used instead.

Screenshots of code assist new behaviour:

Security Schemes

security

OperationId

opids

OperationRef

opirefs

final Collection<Proposal> results = Lists.newArrayList();
final List<AbstractNode> nodes = Lists.newArrayList();
for (AbstractNode node : model.allNodes()) {
if (node.getType() != null && operationPointer.equals(node.getType().getPointer())) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@@ -0,0 +1,43 @@
package com.reprezen.swagedit.core.assist.contexts;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need a copyright header for this other new classes

import com.reprezen.swagedit.core.model.Model;
import com.reprezen.swagedit.core.schema.CompositeSchema;

public abstract class SchemaContextType extends ContextType {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... and a javadoc here :)

Copy link
Member

@tfesenko tfesenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed code review and QA with the these follow up items:

  • add copyright headers
  • add Javadoc to SchemaContextType

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants