Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAPIv3: Code-assist: Custom title properties in JSON Schema #296

Closed
tfesenko opened this issue May 16, 2017 · 2 comments
Closed

OpenAPIv3: Code-assist: Custom title properties in JSON Schema #296

tfesenko opened this issue May 16, 2017 · 2 comments

Comments

@tfesenko
Copy link
Member

Extracted from #291.
We added several custom title properties to the JSON Schema for Swagger v2 in 3b7a120
Check if we need custom titles in OpenAPI v3 and update the Schema generator(#292) accordingly.

@tedepstein
Copy link
Collaborator

Adding to current scope, pending clarification: Will our 3.0 content assist and/or validation use these by default, or will we need to (re-)add custom logic for this purpose?

@tfesenko
Copy link
Member Author

We probably won't need custom title properties. The code which calculates human-friendly label does use title if it's available, but the value of $ref is good enough.

This logic is currently implemented in MultipleSwaggerErrorBuilder.getHumanFriendlyText(JsonNode, String), but it will be moved to a more appropriate location when we decided to use it for code-assist too.

I don't see any cases where we need the custom titles. Closing this issue for now. We can always reopen it if needed.

@tedepstein tedepstein changed the title OpenAPIv3: Code-assist: Custom titleproperties in JSON Schema OpenAPIv3: Code-assist: Custom title properties in JSON Schema Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants