Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore series? #57

Open
Eagle1337 opened this issue Sep 27, 2022 · 11 comments
Open

Ignore series? #57

Eagle1337 opened this issue Sep 27, 2022 · 11 comments
Labels
enhancement New feature or request

Comments

@Eagle1337
Copy link

There's a few series that I have that aren't super consistent with their subtitle naming or have different named japanese/english tracks (even though there's just 1) confuses the hell out of the program.

@RemiRigal RemiRigal added the enhancement New feature or request label Dec 14, 2022
@RemiRigal
Copy link
Owner

Thank you for the suggestion, this could totally be a thing yes.
How would you like to blacklist them ? By name, by their Plex id ?

@Eagle1337
Copy link
Author

Name seems easiest but the most prone to screw ups, but the plex id requires people knowing how to find it.

@RemiRigal
Copy link
Owner

That's exactly what I was thinking.

Another approach could be to use the Plex labels to do so, Plex-Auto-Languages could automatically ignore all tv shows that have the PAL_IGNORE label for example. It can be updated directly from within Plex and would not require a config change for PAL (thus no restart required), which might be simpler. What do you think ?

@Eagle1337
Copy link
Author

That'd also work.

@dphildebrandt
Copy link

I like the idea of tagging the shows in Plex! Furthermore since you can add tags on seasons, it would be great to filter on those, by tag, as well. A great feature for anthology-like shows.

For example, Star Wars Visions: Volume 1 was all Japanese audio with English subtitles. But Volume 2 is all English with one episode being Korean.

Since my config updates by 'season' instead of 'show' its convenient to set the audio/sub for Volume 1, but allowing a episode-by-episode choice on Volume 2.

@Assaro
Copy link

Assaro commented Aug 4, 2023

Solution with tags sounds great. I would like to point out two things:

  1. Make the label name configurable to avoid confusion
  2. Solving that problem is in most cases a better solution. Changing subtitle tags and does not take a long time and only needs to be done once. Cant have confusion when the subs are named correctly :)

@RemiRigal
Copy link
Owner

I just merged the PR #85 that implements this.

I have added a new configuration option called ignore_tags which is a list of Plex tags that PAL will ignore. It defaults to ["PAL_IGNORE"] but can be configure in any way. Only one tag from this list is required to make PAL ignore a show. A log is printed when in debug mode every time a show is ignored based on its tags.

If anyone can try this new feature I would love to get some feedback ! Thanks

I like the idea of tagging the shows in Plex! Furthermore since you can add tags on seasons, it would be great to filter on those, by tag, as well. A great feature for anthology-like shows.

@dphildebrandt How do you add tags on season ? I cannot find the settings using the Plex web UI.

@dphildebrandt
Copy link

dphildebrandt commented Aug 11, 2023

My mistake, you can't!

I had assumed since you could tag shows, and episodes, that seasons were also available for tagging. Woops!

@dphildebrandt
Copy link

dphildebrandt commented Aug 16, 2023

@RemiRigal Hey I'm trying to test it, I dont use a configuration file, I just set environment variables. I tried but im curious how I would set a list of tags in this case? (EDIT: I see in the code/tests its just comma-separated list of strings, might want to update the docs to reflect that)

pal:
    <<: *network-sec
    image: remirigal/plex-auto-languages:latest
    container_name: plex-auto-languages
    secrets:
      - plex_token
    environment:
      <<: *default-tz-puid-pgid
      PLEX_URL: http://192.168.1.29:32400
      PLEX_TOKEN_FILE: /run/secrets/plex_token
      UPDATE_LEVEL: season
      IGNORE_TAGS: PAL_IGNORE

I restarted it and saw in the logs
2023-08-16 09:00:41,664 [INFO] Setting value of parameter IGNORE_TAGS from environment variable

I tagged a show under Tags -> Genres watched the show, and it still updated the remaining season's audio/subs.

I then moved the tag to Tags -> Collection watched the show, and it still updated the remaining season's audio/subs.

I then moved the tag to Labels -> Labels watched the show, and it correctly output the debug log and did not change the remainder of the season!

So, I'm not sure if you intended any tagged area to work, or just the labels. It makes sense (since its not a genre or collection), but first instinct when using "tags" is to go to the Tags portion of the UI when editing.

Maybe update docs, or dont call it "tags" but "labels" instead?

@dphildebrandt
Copy link

Also, I'm not sure if it's intended, but as an episode is playing, it keeps pumping out the message over and over every 10 seconds
image

@RemiRigal
Copy link
Owner

Maybe update docs, or dont call it "tags" but "labels" instead?

You are absolutely right, the API had me a bit confused about the naming scheme. I will change it to labels, make sure that you change the name of your environment variable for the next release. Thanks !

Also, I'm not sure if it's intended, but as an episode is playing, it keeps pumping out the message over and over every 10 seconds

Plex sends updates every 10 seconds during a play session, since the progress of the play session is not monitored for ignored shows it has to check every time. I would say that it's an intended behavior considering that this message is printed only in debug mode, but any suggestion on doing things differently is more than welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants